cpufreq: mediatek: fix error return code in mtk_cpu_dvfs_info_init()
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 17 May 2022 13:34:50 +0000 (21:34 +0800)
committerViresh Kumar <viresh.kumar@linaro.org>
Wed, 13 Jul 2022 11:23:00 +0000 (16:53 +0530)
If regulator_get_voltage() fails, it should return the error code in
mtk_cpu_dvfs_info_init().

Fixes: 0daa47325bae ("cpufreq: mediatek: Link CCI device to CPU")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/mediatek-cpufreq.c

index 76f6b3884e6b2dc070e20f51f592d48ef04bf15d..7f2680bc9a0f4d110ad397c3480dd8228eb4ea5c 100644 (file)
@@ -478,6 +478,7 @@ static int mtk_cpu_dvfs_info_init(struct mtk_cpu_dvfs_info *info, int cpu)
        if (info->soc_data->ccifreq_supported) {
                info->vproc_on_boot = regulator_get_voltage(info->proc_reg);
                if (info->vproc_on_boot < 0) {
+                       ret = info->vproc_on_boot;
                        dev_err(info->cpu_dev,
                                "invalid Vproc value: %d\n", info->vproc_on_boot);
                        goto out_disable_inter_clock;