ptp: ocp: off by in in ptp_ocp_tod_gnss_name()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 7 Mar 2022 14:13:18 +0000 (17:13 +0300)
committerJakub Kicinski <kuba@kernel.org>
Mon, 7 Mar 2022 23:12:05 +0000 (15:12 -0800)
The > ARRAY_SIZE() needs to be >= ARRAY_SIZE() to prevent an out of
bounds access.

Fixes: 9f492c4cb235 ("ptp: ocp: add TOD debug information")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Link: https://lore.kernel.org/r/20220307141318.GA18867@kili
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/ptp/ptp_ocp.c

index aaefca6c2422220595b7f15a3d51fd9b0024c260..334435e77b2ff193d7eb9264b9c7d30979dda1fb 100644 (file)
@@ -914,7 +914,7 @@ ptp_ocp_tod_gnss_name(int idx)
                "ALL", "COMBINED", "GPS", "GLONASS", "GALILEO", "BEIDOU",
                "Unknown"
        };
-       if (idx > ARRAY_SIZE(gnss_name))
+       if (idx >= ARRAY_SIZE(gnss_name))
                idx = ARRAY_SIZE(gnss_name) - 1;
        return gnss_name[idx];
 }