USB: host: isp1362: remove dentry pointer for debugfs

There is no need to keep the dentry pointer around for the created
debugfs file, as it is only needed when removing it from the system.
When it is to be removed, ask debugfs itself for the pointer, to save on
storage and make things a bit simpler.

Cc: linux-usb@vger.kernel.org
Link: https://lore.kernel.org/r/20210216144645.3813043-2-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/host/isp1362-hcd.c b/drivers/usb/host/isp1362-hcd.c
index 2cecb36d241b4911550410e6ce3e4daea0d8ad3f..d8610ce8f2ecd4f87eb3034b8ee6681806c6941f 100644 (file)
--- a/drivers/usb/host/isp1362-hcd.c
+++ b/drivers/usb/host/isp1362-hcd.c
@@ -2164,15 +2164,13 @@ DEFINE_SHOW_ATTRIBUTE(isp1362);
 /* expect just one isp1362_hcd per system */
 static void create_debug_file(struct isp1362_hcd *isp1362_hcd)
 {
-       isp1362_hcd->debug_file = debugfs_create_file("isp1362", S_IRUGO,
-                                                     usb_debug_root,
-                                                     isp1362_hcd,
-                                                     &isp1362_fops);
+       debugfs_create_file("isp1362", S_IRUGO, usb_debug_root, isp1362_hcd,
+                           &isp1362_fops);
 }
 
 static void remove_debug_file(struct isp1362_hcd *isp1362_hcd)
 {
-       debugfs_remove(isp1362_hcd->debug_file);
+       debugfs_remove(debugfs_lookup("isp1362", usb_debug_root));
 }
 
 /*-------------------------------------------------------------------------*/

diff --git a/drivers/usb/host/isp1362.h b/drivers/usb/host/isp1362.h
index 208705b08d37574db12bdfbe3df8a3bdf03ccf97..74ca4be24723ea68bcbae6c986f24a11959b0f42 100644 (file)
--- a/drivers/usb/host/isp1362.h
+++ b/drivers/usb/host/isp1362.h
@@ -435,7 +435,6 @@ struct isp1362_hcd {
 
        struct isp1362_platform_data *board;
 
-       struct dentry           *debug_file;
        unsigned long           stat1, stat2, stat4, stat8, stat16;
 
        /* HC registers */