staging: r8188: ODM_BB_RA_MASK is always set
authorMartin Kaiser <martin@kaiser.cx>
Sat, 18 Dec 2021 12:04:23 +0000 (13:04 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 Dec 2021 16:51:15 +0000 (17:51 +0100)
Remove the ODM_BB_RA_MASK capability. It is always set for this driver.

Like for ODM_BB_DIG before, we can be sure that ODM_BB_RA_MASK was never
checked before it was set.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20211218120423.29906-10-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/odm.c
drivers/staging/r8188eu/hal/rtl8188e_dm.c
drivers/staging/r8188eu/include/odm.h

index 70c83465a0a6ca0f129796b1ef9cb5e0e8ff4aef..7a42687b31286c9235b8e059ad191b4710ca8c02 100644 (file)
@@ -725,9 +725,6 @@ void odm_RefreshRateAdaptiveMask(struct odm_dm_struct *pDM_Odm)
        u8 i;
        struct adapter *pAdapter = pDM_Odm->Adapter;
 
-       if (!(pDM_Odm->SupportAbility & ODM_BB_RA_MASK))
-               return;
-
        if (pAdapter->bDriverStopped)
                return;
 
index 865e520a246d71e6e7f1b5f027377fa7bdbf2316..6854310344953ebc532b39118af79fed28056e7d 100644 (file)
@@ -53,8 +53,7 @@ static void Update_ODM_ComInfo_88E(struct adapter *Adapter)
        struct dm_priv  *pdmpriv = &hal_data->dmpriv;
        int i;
 
-       pdmpriv->InitODMFlag = ODM_BB_RA_MASK |
-                               ODM_BB_FA_CNT |
+       pdmpriv->InitODMFlag = ODM_BB_FA_CNT |
                                ODM_BB_RSSI_MONITOR |
                                ODM_BB_CCK_PD |
                                ODM_MAC_EDCA_TURBO |
index 6199190e5426dcad43d035bcaa2c77e8a8c627f5..19e859b989adb97aa91444e53b7907f09bedd49f 100644 (file)
@@ -240,7 +240,6 @@ enum odm_common_info_def {
 
 enum odm_ability_def {
        /*  BB ODM section BIT 0-15 */
-       ODM_BB_RA_MASK                  = BIT(1),
        ODM_BB_FA_CNT                   = BIT(3),
        ODM_BB_RSSI_MONITOR             = BIT(4),
        ODM_BB_CCK_PD                   = BIT(5),