iio: potentiometer: ds1803: Add support for Maxim DS3502

The DS3502 is a 7-bit, nonvolatile digital potentiometer featuring
an output voltage range of up to 15.5V. DS3502 support is added
into existing DS1803 driver.

Datasheet: https://datasheets.maximintegrated.com/en/ds/DS3502.pdf
Signed-off-by: Jagath Jog J <jagathjog1996@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20220223163525.13399-7-jagathjog1996@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/potentiometer/Kconfig b/drivers/iio/potentiometer/Kconfig
index 832df8da2bc6639b5ccd02f4fb8be7afbc2e4c43..01dd3f858d99cb78df9b5dadbaa2b1bf53125cf6 100644 (file)
--- a/drivers/iio/potentiometer/Kconfig
+++ b/drivers/iio/potentiometer/Kconfig
@@ -27,11 +27,11 @@ config AD5272
          module will be called ad5272.
 
 config DS1803
-       tristate "Maxim Integrated DS1803 Digital Potentiometer driver"
+       tristate "Maxim Integrated DS1803 and similar Digital Potentiometer driver"
        depends on I2C
        help
-         Say yes here to build support for the Maxim Integrated DS1803
-         digital potentiometer chip.
+         Say yes here to build support for the Maxim Integrated DS1803 and
+         DS3502 digital potentiometer chip.
 
          To compile this driver as a module, choose M here: the
          module will be called ds1803.

diff --git a/drivers/iio/potentiometer/ds1803.c b/drivers/iio/potentiometer/ds1803.c
index 017afa9fc83da038d8dd5371efe36b4f822c562e..5c212ed7a93133de40c129e9f766b4c4eb490aa6 100644 (file)
--- a/drivers/iio/potentiometer/ds1803.c
+++ b/drivers/iio/potentiometer/ds1803.c
@@ -1,12 +1,15 @@
 // SPDX-License-Identifier: GPL-2.0-only
 /*
- * Maxim Integrated DS1803 digital potentiometer driver
+ * Maxim Integrated DS1803 and similar digital potentiometer driver
  * Copyright (c) 2016 Slawomir Stepien
+ * Copyright (c) 2022 Jagath Jog J
  *
  * Datasheet: https://datasheets.maximintegrated.com/en/ds/DS1803.pdf
+ * Datasheet: https://datasheets.maximintegrated.com/en/ds/DS3502.pdf
  *
  * DEVID       #Wipers #Positions      Resistor Opts (kOhm)    i2c address
  * ds1803      2       256             10, 50, 100             0101xxx
+ * ds3502      1       128             10                      01010xx
  */
 
 #include <linux/err.h>
@@ -19,11 +22,13 @@
 
 #define DS1803_WIPER_0         0xA9
 #define DS1803_WIPER_1         0xAA
+#define DS3502_WR_IVR          0x00
 
 enum ds1803_type {
        DS1803_010,
        DS1803_050,
        DS1803_100,
+       DS3502,
 };
 
 struct ds1803_cfg {
@@ -57,6 +62,10 @@ static const struct iio_chan_spec ds1803_channels[] = {
        DS1803_CHANNEL(1, DS1803_WIPER_1),
 };
 
+static const struct iio_chan_spec ds3502_channels[] = {
+       DS1803_CHANNEL(0, DS3502_WR_IVR),
+};
+
 static int ds1803_read(struct iio_dev *indio_dev,
                       struct iio_chan_spec const *chan,
                       int *val)
@@ -73,6 +82,21 @@ static int ds1803_read(struct iio_dev *indio_dev,
        return ret;
 }
 
+static int ds3502_read(struct iio_dev *indio_dev,
+                      struct iio_chan_spec const *chan,
+                      int *val)
+{
+       struct ds1803_data *data = iio_priv(indio_dev);
+       int ret;
+
+       ret = i2c_smbus_read_byte_data(data->client, chan->address);
+       if (ret < 0)
+               return ret;
+
+       *val = ret;
+       return ret;
+}
+
 static const struct ds1803_cfg ds1803_cfg[] = {
        [DS1803_010] = {
                .wipers = 2,
@@ -98,6 +122,14 @@ static const struct ds1803_cfg ds1803_cfg[] = {
                .num_channels = ARRAY_SIZE(ds1803_channels),
                .read = ds1803_read,
        },
+       [DS3502] = {
+         .wipers = 1,
+         .avail = { 0, 1, 127 },
+         .kohms =  10,
+         .channels = ds3502_channels,
+         .num_channels = ARRAY_SIZE(ds3502_channels),
+         .read = ds3502_read,
+       },
 };
 
 static int ds1803_read_raw(struct iio_dev *indio_dev,
@@ -200,6 +232,7 @@ static const struct of_device_id ds1803_dt_ids[] = {
        { .compatible = "maxim,ds1803-010", .data = &ds1803_cfg[DS1803_010] },
        { .compatible = "maxim,ds1803-050", .data = &ds1803_cfg[DS1803_050] },
        { .compatible = "maxim,ds1803-100", .data = &ds1803_cfg[DS1803_100] },
+       { .compatible = "maxim,ds3502", .data = &ds1803_cfg[DS3502] },
        {}
 };
 MODULE_DEVICE_TABLE(of, ds1803_dt_ids);
@@ -208,6 +241,7 @@ static const struct i2c_device_id ds1803_id[] = {
        { "ds1803-010", DS1803_010 },
        { "ds1803-050", DS1803_050 },
        { "ds1803-100", DS1803_100 },
+       { "ds3502", DS3502 },
        {}
 };
 MODULE_DEVICE_TABLE(i2c, ds1803_id);
@@ -224,5 +258,6 @@ static struct i2c_driver ds1803_driver = {
 module_i2c_driver(ds1803_driver);
 
 MODULE_AUTHOR("Slawomir Stepien <sst@poczta.fm>");
+MODULE_AUTHOR("Jagath Jog J <jagathjog1996@gmail.com>");
 MODULE_DESCRIPTION("DS1803 digital potentiometer");
 MODULE_LICENSE("GPL v2");