bfs_add_entry(): get rid of pointless ->d_name.len checks
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 12 Nov 2023 21:56:19 +0000 (16:56 -0500)
committerAl Viro <viro@zeniv.linux.org.uk>
Wed, 20 Dec 2023 17:09:32 +0000 (12:09 -0500)
First of all, any dentry getting here would have passed bfs_lookup(),
so it it passed ENAMETOOLONG check there, there's no need to
repeat it.  And we are not going to get dentries with zero name length -
that check ultimately comes from ext2 and it's as pointless here as it
used to be there.

Acked-by: Tigran Aivazian <aivazian.tigran@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/bfs/dir.c

index fbc4ae80a4b22ebeca21e407d44aed1267f8d593..c375e22c4c0c15ba27307d266adfe3f093b90ab8 100644 (file)
@@ -275,11 +275,6 @@ static int bfs_add_entry(struct inode *dir, const struct qstr *child, int ino)
 
        dprintf("name=%s, namelen=%d\n", name, namelen);
 
-       if (!namelen)
-               return -ENOENT;
-       if (namelen > BFS_NAMELEN)
-               return -ENAMETOOLONG;
-
        sblock = BFS_I(dir)->i_sblock;
        eblock = BFS_I(dir)->i_eblock;
        for (block = sblock; block <= eblock; block++) {