perf/x86/amd/uncore: Fix uninitialized return value in amd_uncore_init()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 13 Oct 2023 07:18:12 +0000 (10:18 +0300)
committerIngo Molnar <mingo@kernel.org>
Fri, 13 Oct 2023 07:32:50 +0000 (09:32 +0200)
Some of the error paths in this function return don't initialize the
error code.  Return -ENODEV by default.

Fixes: d6389d3ccc13 ("perf/x86/amd/uncore: Refactor uncore management")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/cec62eba-c4b8-4cb7-9671-58894dd4b974@moroto.mountain
arch/x86/events/amd/uncore.c

index 9b444ce24108ee78c6b54fd83aaea73ce1beec2c..a389828f378caafc78e3e7e6f3c00db42a81cc48 100644 (file)
@@ -1009,7 +1009,8 @@ static struct amd_uncore uncores[UNCORE_TYPE_MAX] = {
 static int __init amd_uncore_init(void)
 {
        struct amd_uncore *uncore;
-       int ret, i;
+       int ret = -ENODEV;
+       int i;
 
        if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD &&
            boot_cpu_data.x86_vendor != X86_VENDOR_HYGON)