projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
041c346
)
ptp: prevent string overflow
author
Dan Carpenter
<dan.carpenter@linaro.org>
Wed, 18 Oct 2023 14:20:11 +0000
(17:20 +0300)
committer
Jakub Kicinski
<kuba@kernel.org>
Thu, 19 Oct 2023 22:51:52 +0000
(15:51 -0700)
The ida_alloc_max() function can return up to INT_MAX so this buffer is
not large enough. Also use snprintf() for extra safety.
Fixes: 403376ddb422 ("ptp: add debugfs interface to see applied channel masks")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Link:
https://lore.kernel.org/r/d4b1a995-a0cb-4125-aa1d-5fd5044aba1d@moroto.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/ptp/ptp_clock.c
patch
|
blob
|
history
diff --git
a/drivers/ptp/ptp_clock.c
b/drivers/ptp/ptp_clock.c
index 2e801cd3322005dd24cc06a8d0e5eff2e7273eef..3d1b0a97301c95cc9daf9d298a8b85974af1cda5 100644
(file)
--- a/
drivers/ptp/ptp_clock.c
+++ b/
drivers/ptp/ptp_clock.c
@@
-220,7
+220,7
@@
struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
struct ptp_clock *ptp;
struct timestamp_event_queue *queue = NULL;
int err = 0, index, major = MAJOR(ptp_devt);
- char debugfsname[
8
];
+ char debugfsname[
16
];
size_t size;
if (info->n_alarm > PTP_MAX_ALARMS)
@@
-343,7
+343,7
@@
struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
}
/* Debugfs initialization */
- s
printf(debugfsname
, "ptp%d", ptp->index);
+ s
nprintf(debugfsname, sizeof(debugfsname)
, "ptp%d", ptp->index);
ptp->debugfs_root = debugfs_create_dir(debugfsname, NULL);
return ptp;