scsi: ufs: ufs-mediatek: Remove redundant dev_err()
authorYang Li <yang.lee@linux.alibaba.com>
Wed, 12 Jul 2023 06:48:32 +0000 (14:48 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sun, 23 Jul 2023 19:27:14 +0000 (15:27 -0400)
There is no need to call the dev_err() function directly to print a custom
message when handling an error from either the platform_get_irq() or
platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

./drivers/ufs/host/ufs-mediatek.c:864:3-10: line 864 is redundant because platform_get_irq() already prints an error

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5846
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/20230712064832.44188-1-yang.lee@linux.alibaba.com
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/host/ufs-mediatek.c

index 786b1469eb52ceb9474c046c72005f682fcb9a31..b499eade957eeda0d22b2fa82fe1c91ac1db6b72 100644 (file)
@@ -861,7 +861,6 @@ static void ufs_mtk_init_mcq_irq(struct ufs_hba *hba)
                irq = platform_get_irq(pdev, i + 1);
                if (irq < 0) {
                        host->mcq_intr_info[i].irq = MTK_MCQ_INVALID_IRQ;
-                       dev_err(hba->dev, "get platform mcq irq fail: %d\n", i);
                        goto failed;
                }
                host->mcq_intr_info[i].hba = hba;