virtio-mem-pci: Fix memory leak when creating MEMORY_DEVICE_SIZE_CHANGE event
authorDavid Hildenbrand <david@redhat.com>
Wed, 29 Sep 2021 16:24:43 +0000 (18:24 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Sat, 2 Oct 2021 06:43:21 +0000 (08:43 +0200)
Apparently, we don't have to duplicate the string.

Fixes: 722a3c783ef4 ("virtio-pci: Send qapi events when the virtio-mem size changes")
Cc: qemu-stable@nongnu.org
Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20210929162445.64060-2-david@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/virtio/virtio-mem-pci.c

index fa5395cd88577964fba445c68f2d025b504f5544..7e384b7397edf9014c4e81df4ff51a640ed66efe 100644 (file)
@@ -88,13 +88,8 @@ static void virtio_mem_pci_size_change_notify(Notifier *notifier, void *data)
                                          size_change_notifier);
     DeviceState *dev = DEVICE(pci_mem);
     const uint64_t * const size_p = data;
-    const char *id = NULL;
 
-    if (dev->id) {
-        id = g_strdup(dev->id);
-    }
-
-    qapi_event_send_memory_device_size_change(!!id, id, *size_p);
+    qapi_event_send_memory_device_size_change(!!dev->id, dev->id, *size_p);
 }
 
 static void virtio_mem_pci_class_init(ObjectClass *klass, void *data)