And a Hugo global variable which contains the site under build.
This is really needed to get some level of control of the "multiple languages" in play.
There are still work related to this scattered around, but that will come.
With this commit, the multilingual feature is starting to work.
return err
}
for i := 0; i < benchmarkTimes; i++ {
- Sites = nil
- _ = buildSite()
+ _ = buildSites()
+ Hugo.Reset()
}
pprof.WriteHeapProfile(f)
f.Close()
pprof.StartCPUProfile(f)
defer pprof.StopCPUProfile()
for i := 0; i < benchmarkTimes; i++ {
- Sites = nil
- _ = buildSite()
+ _ = buildSites()
+ Hugo.Reset()
}
}
"github.com/spf13/viper"
)
-// Sites represents the Hugo sites to build. This variable is exported as it
+type HugoSites []*hugolib.Site
+
+// Reset resets the sites, making it ready for a full rebuild.
+// TODO(bep) multilingo
+func (h HugoSites) Reset() {
+ for i, s := range h {
+ h[i] = s.Reset()
+ }
+}
+
+// Hugo represents the Hugo sites to build. This variable is exported as it
// is used by at least one external library (the Hugo caddy plugin). We should
// provide a cleaner external API, but until then, this is it.
-var Sites map[string]*hugolib.Site
+var Hugo HugoSites
// Reset resets Hugo ready for a new full build. This is mainly only useful
// for benchmark testing etc. via the CLI commands.
helpers.HugoReleaseVersion(), minVersion)
}
- return readMultilingualConfiguration()
+ h, err := readMultilingualConfiguration()
+
+ if err != nil {
+ return err
+ }
+ //TODO(bep) refactor ...
+ Hugo = h
+
+ return nil
}
viper.OnConfigChange(func(e fsnotify.Event) {
fmt.Println("Config file changed:", e.Name)
// Force a full rebuild
- Sites = nil
- utils.CheckErr(buildSite(true))
+ Hugo.Reset()
+ utils.CheckErr(buildSites(true))
if !viper.GetBool("DisableLiveReload") {
// Will block forever trying to write to a channel that nobody is reading if livereload isn't initialized
livereload.ForceRefresh()
if len(watches) > 0 && watches[0] {
watch = true
}
- if err := buildSite(buildWatch || watch); err != nil {
+ if err := buildSites(buildWatch || watch); err != nil {
return fmt.Errorf("Error building site: %s", err)
}
return a
}
-func buildSite(watching ...bool) (err error) {
+func buildSites(watching ...bool) (err error) {
fmt.Println("Started building site")
t0 := time.Now()
- if Sites == nil {
- Sites = make(map[string]*hugolib.Site)
- }
-
- for _, lang := range langConfigsList {
+ for _, site := range Hugo {
t1 := time.Now()
- mainSite, present := Sites[lang.Lang]
- if !present {
- mainSite = new(hugolib.Site)
- Sites[lang.Lang] = mainSite
- mainSite.SetMultilingualConfig(lang, langConfigsList)
- }
-
if len(watching) > 0 && watching[0] {
- mainSite.RunMode.Watching = true
+ site.RunMode.Watching = true
}
- if err := mainSite.Build(); err != nil {
+ if err := site.Build(); err != nil {
return err
}
- mainSite.Stats(lang.Lang, t1)
+ site.Stats(t1)
}
jww.FEEDBACK.Printf("total in %v ms\n", int(1000*time.Since(t0).Seconds()))
return nil
}
-func rebuildSite(events []fsnotify.Event) error {
+func rebuildSites(events []fsnotify.Event) error {
t0 := time.Now()
- for _, lang := range langConfigsList {
+ for _, site := range Hugo {
t1 := time.Now()
- site := Sites[lang.Lang]
if err := site.ReBuild(events); err != nil {
return err
}
- site.Stats(lang.Lang, t1)
+ site.Stats(t1)
}
jww.FEEDBACK.Printf("total in %v ms\n", int(1000*time.Since(t0).Seconds()))
const layout = "2006-01-02 15:04 -0700"
fmt.Println(time.Now().Format(layout))
- rebuildSite(dynamicEvents)
+ rebuildSites(dynamicEvents)
if !buildWatch && !viper.GetBool("DisableLiveReload") {
// Will block forever trying to write to a channel that nobody is reading if livereload isn't initialized
"github.com/spf13/viper"
)
-var langConfigsList hugolib.Languages
-
-func readMultilingualConfiguration() error {
+func readMultilingualConfiguration() (HugoSites, error) {
+ h := make(HugoSites, 0)
multilingual := viper.GetStringMap("Multilingual")
if len(multilingual) == 0 {
// TODO(bep) multilingo langConfigsList = append(langConfigsList, hugolib.NewLanguage("en"))
- return nil
+ h = append(h, hugolib.NewSite(hugolib.NewLanguage("en")))
+ return h, nil
}
var err error
- langConfigsList, err = toSortedLanguages(multilingual)
+ langConfigsList, err := toSortedLanguages(multilingual)
if err != nil {
- return fmt.Errorf("Failed to parse multilingual config: %s", err)
+ return nil, fmt.Errorf("Failed to parse multilingual config: %s", err)
+ }
+
+ for _, lang := range langConfigsList {
+ s := hugolib.NewSite(lang)
+ s.SetMultilingualConfig(lang, langConfigsList)
+ h = append(h, s)
}
- return nil
+ return h, nil
}
func toSortedLanguages(l map[string]interface{}) (hugolib.Languages, error) {
sources := []source.ByteSource{
{Name: filepath.FromSlash("test.roml"), Content: []byte("boo")},
}
- s := &Site{}
+ s := newSiteDefaultLang()
err := s.loadData([]source.Input{&source.InMemorySource{ByteSource: sources}})
if err != nil {
t.Fatalf("Should not return an error")
}
func doTestDataDir(t *testing.T, expected interface{}, sources []source.Input) {
- s := &Site{}
+ s := newSiteDefaultLang()
err := s.loadData(sources)
if err != nil {
t.Fatalf("Error loading data: %s", err)
s := &Site{
Source: &source.InMemorySource{ByteSource: sources},
targets: targetList{page: &target.PagePub{UglyURLs: true}},
+ Lang: NewLanguage("en"),
}
s.initializeSiteInfo()
s := &Site{
Source: &source.InMemorySource{ByteSource: pageSources},
+ Lang: newDefaultLanguage(),
}
return s
}
return &Language{Lang: lang, params: make(map[string]interface{})}
}
+// TODO(bep) multilingo
+func newDefaultLanguage() *Language {
+ return NewLanguage("en")
+}
+
type Languages []*Language
func NewLanguages(l ...*Language) Languages {
return viper.Get(key)
}
+// TODO(bep) multilingo move this to a constructor.
func (s *Site) SetMultilingualConfig(currentLang *Language, languages Languages) {
- // TODO(bep) multilingo evaluate
- viper.Set("CurrentLanguage", currentLang)
ml := &Multilingual{
Languages: languages,
}
return s.Multilingual != nil && s.Multilingual.enabled()
}
-func currentLanguageString() string {
- return currentLanguage().Lang
+// TODO(bep) multilingo remove these
+func (s *Site) currentLanguageString() string {
+ return s.currentLanguage().Lang
}
-func currentLanguage() *Language {
- l := viper.Get("CurrentLanguage")
- if l == nil {
- panic("CurrentLanguage not set")
- }
- return l.(*Language)
+func (s *Site) currentLanguage() *Language {
+ return s.Lang
}
viper.Set("paginate", -1)
}
pages := createTestPages(12)
- s := &Site{}
+ s := newSiteDefaultLang()
n1 := s.newHomeNode()
n2 := s.newHomeNode()
n1.Data["Pages"] = pages
defer viper.Reset()
viper.Set("paginate", -1)
- s := &Site{}
+ s := newSiteDefaultLang()
_, err := s.newHomeNode().Paginator()
assert.NotNil(t, err)
}
}
pages := createTestPages(6)
- s := &Site{}
+ s := newSiteDefaultLang()
n1 := s.newHomeNode()
n2 := s.newHomeNode()
}
func TestInvalidOptions(t *testing.T) {
- s := &Site{}
+ s := newSiteDefaultLang()
n1 := s.newHomeNode()
_, err := n1.Paginate(createTestPages(1), 1, 2)
assert.NotNil(t, err)
defer viper.Reset()
viper.Set("paginate", -1)
- s := &Site{}
+ s := newSiteDefaultLang()
_, err := s.newHomeNode().Paginate(createTestPages(2))
assert.NotNil(t, err)
}
defer viper.Reset()
viper.Set("paginate", 10)
- s := &Site{}
+ s := newSiteDefaultLang()
n1 := s.newHomeNode()
n2 := s.newHomeNode()
defer viper.Reset()
viper.Set("paginate", 10)
- s := &Site{}
+ s := newSiteDefaultLang()
n1 := s.newHomeNode()
n2 := s.newHomeNode()
s := &Site{
Source: &source.InMemorySource{ByteSource: weightedSources},
+ Lang: newDefaultLanguage(),
}
s.initializeSiteInfo()
hugofs.InitMemFs()
s := &Site{
Source: &source.InMemorySource{ByteSource: weightedSources},
+ Lang: newDefaultLanguage(),
}
s.initializeSiteInfo()
s.prepTemplates("rss.xml", rssTemplate)
s := &Site{
Source: &source.InMemorySource{ByteSource: sources},
targets: targetList{page: &target.PagePub{UglyURLs: false}},
+ Lang: newDefaultLanguage(),
}
s.initializeSiteInfo()
futureCount int
expiredCount int
Data map[string]interface{}
+ Lang *Language
+}
+
+// TODO(bep) multilingo
+// Reset returns a new Site prepared for rebuild.
+func (s *Site) Reset() *Site {
+ return &Site{Lang: s.Lang, Multilingual: s.Multilingual}
+}
+
+func NewSite(lang *Language) *Site {
+ return &Site{Lang: lang}
+}
+
+func newSiteDefaultLang() *Site {
+ return NewSite(newDefaultLanguage())
}
type targetList struct {
i18nSources = []source.Input{&source.Filesystem{Base: themeI18nDir}, i18nSources[0]}
}
- if err = loadI18n(i18nSources, currentLanguageString()); err != nil {
+ if err = loadI18n(i18nSources, s.currentLanguageString()); err != nil {
return
}
s.timerStep("load i18n")
return
}
- currentLang := currentLanguageString()
+ currentLang := s.currentLanguageString()
allTranslations := pagesToTranslationsMap(s.Multilingual, s.AllPages)
assignTranslationsToPages(allTranslations, s.AllPages)
func (s *Site) initializeSiteInfo() {
var (
- lang *Language
+ lang *Language = s.Lang
languages Languages
)
- cl := viper.Get("CurrentLanguage")
- if cl == nil {
- // Set default to english
- // TODO(bep) multilingo this looks clumsy
- lang = NewLanguage("en")
- viper.Set("CurrentLanguage", lang)
- } else {
- lang = cl.(*Language)
- }
-
if s.Multilingual != nil {
languages = s.Multilingual.Languages
}
func (s *Site) addMultilingualPrefix(basePath string) string {
hadPrefix := strings.HasPrefix(basePath, "/")
if s.multilingualEnabled() {
- basePath = path.Join(currentLanguageString(), basePath)
+ basePath = path.Join(s.currentLanguageString(), basePath)
if hadPrefix {
basePath = "/" + basePath
}
// Stats prints Hugo builds stats to the console.
// This is what you see after a successful hugo build.
-func (s *Site) Stats(lang string, t0 time.Time) {
+func (s *Site) Stats(t0 time.Time) {
jww.FEEDBACK.Println(s.draftStats())
jww.FEEDBACK.Println(s.futureStats())
jww.FEEDBACK.Println(s.expiredStats())
jww.FEEDBACK.Printf("%d %s created\n", len(s.Taxonomies[pl]), pl)
}
- if lang != "" {
- jww.FEEDBACK.Printf("rendered lang %q in %v ms\n", lang, int(1000*time.Since(t0).Seconds()))
- }
+ // TODO(bep) will always have lang. Not sure this should always be printed.
+ jww.FEEDBACK.Printf("rendered lang %q in %v ms\n", s.Lang.Lang, int(1000*time.Since(t0).Seconds()))
+
}
func (s *Site) setURLs(n *Node, in string) {
for i, test := range tests {
- s := &Site{}
+ s := newSiteDefaultLang()
p, err := NewPageFrom(strings.NewReader(pageSimpleTitle), "content/a/file.md")
if err != nil {
siteSetup := func() *Site {
s := &Site{
Source: &source.InMemorySource{ByteSource: sources},
+ Lang: newDefaultLanguage(),
}
s.initializeSiteInfo()
siteSetup := func() *Site {
s := &Site{
Source: &source.InMemorySource{ByteSource: sources},
+ Lang: newDefaultLanguage(),
}
s.initializeSiteInfo()
s := &Site{
Source: &source.InMemorySource{ByteSource: sources},
targets: targetList{page: &target.PagePub{UglyURLs: uglyURLs}},
+ Lang: newDefaultLanguage(),
}
s.initializeSiteInfo()
s := &Site{
Source: &source.InMemorySource{ByteSource: sources},
targets: targetList{page: &target.PagePub{UglyURLs: uglyURLs}},
+ Lang: newDefaultLanguage(),
}
s.initializeSiteInfo()
s := &Site{
Source: &source.InMemorySource{ByteSource: sources},
targets: targetList{page: &target.PagePub{UglyURLs: uglify}},
+ Lang: newDefaultLanguage(),
}
s.initializeSiteInfo()
s := &Site{
Source: &source.InMemorySource{ByteSource: sources},
targets: targetList{page: &target.PagePub{UglyURLs: true}},
+ Lang: newDefaultLanguage(),
}
s.initializeSiteInfo()
s := &Site{
Source: &source.InMemorySource{ByteSource: sources},
targets: targetList{page: &target.PagePub{UglyURLs: true}},
+ Lang: newDefaultLanguage(),
}
t.Logf("Rendering with BaseURL %q and CanonifyURLs set %v", viper.GetString("baseURL"), canonify)
s.initializeSiteInfo()
viper.Set("baseurl", "http://auth/bub")
s := &Site{
Source: &source.InMemorySource{ByteSource: weightedSources},
+ Lang: newDefaultLanguage(),
}
s.initializeSiteInfo()
viper.Set("taxonomies", taxonomies)
s := &Site{
Source: &source.InMemorySource{ByteSource: sources},
+ Lang: newDefaultLanguage(),
}
s.initializeSiteInfo()
site := &Site{
Source: &source.InMemorySource{ByteSource: sources},
+ Lang: newDefaultLanguage(),
}
site.initializeSiteInfo()
// Multilingual settings
viper.Set("Multilingual", true)
en := NewLanguage("en")
- viper.Set("CurrentLanguage", en)
viper.Set("DefaultContentLanguage", "fr")
viper.Set("paginate", "2")
languages := NewLanguages(en, NewLanguage("fr"))
s := &Site{
Source: &source.InMemorySource{ByteSource: sources},
+ Lang: en,
Multilingual: &Multilingual{
Languages: languages,
},
{"http://base.com", "http://base.com"}} {
viper.Set("BaseURL", this.in)
- s := &Site{}
+ s := newSiteDefaultLang()
s.initializeSiteInfo()
if s.Info.BaseURL != template.URL(this.expected) {
viper.Set("paginate", 10)
s := &Site{
Source: &source.InMemorySource{ByteSource: urlFakeSource},
+ Lang: newDefaultLanguage(),
}
s.initializeSiteInfo()
s.prepTemplates("indexes/blue.html", indexTemplate)
defer viper.Reset()
viper.Set("Params", map[string]interface{}{"MyGlobalParam": "FOOBAR_PARAM"})
- s := &Site{}
+ s := newSiteDefaultLang()
s.initialize()
if s.Info.Params["MyGlobalParam"] != "FOOBAR_PARAM" {
defer viper.Reset()
viper.Set("Permalinks", map[string]interface{}{"section": "/:title"})
- s := &Site{}
+ s := newSiteDefaultLang()
s.initialize()
permalink := s.Info.Permalinks["section"]
"bytes"
"testing"
+ "reflect"
+
"github.com/spf13/hugo/helpers"
"github.com/spf13/hugo/hugofs"
"github.com/spf13/hugo/source"
"github.com/spf13/viper"
- "reflect"
)
const SITEMAP_TEMPLATE = `<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
s := &Site{
Source: &source.InMemorySource{ByteSource: weightedSources},
+ Lang: newDefaultLanguage(),
}
s.initializeSiteInfo()