tty: hvc: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n
authorYang Yingliang <yangyingliang@huawei.com>
Sat, 19 Sep 2020 06:35:35 +0000 (14:35 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 27 Sep 2020 12:17:43 +0000 (14:17 +0200)
aarch64-linux-gnu-ld: drivers/tty/hvc/hvc_dcc.o: in function `dcc_early_write':
hvc_dcc.c:(.text+0x164): undefined reference to `uart_console_write'

The driver uses the uart_console_write(), but SERIAL_CORE_CONSOLE is not
selected, so uart_console_write is not defined, then we get the error.
Fix this by selecting SERIAL_CORE_CONSOLE.

Fixes: d1a1af2cdf19 ("hvc: dcc: Add earlycon support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20200919063535.2809707-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/hvc/Kconfig

index d1b27b0522a3cde22e9ecb1ebc943a5a743c102f..8d60e0ff67b4d4085ec3df7070ec68941e8f4d45 100644 (file)
@@ -81,6 +81,7 @@ config HVC_DCC
        bool "ARM JTAG DCC console"
        depends on ARM || ARM64
        select HVC_DRIVER
+       select SERIAL_CORE_CONSOLE
        help
          This console uses the JTAG DCC on ARM to create a console under the HVC
          driver. This console is used through a JTAG only on ARM. If you don't have