net: dsa: b53: remove unnecessary set_drvdata()
authorYang Yingliang <yangyingliang@huawei.com>
Wed, 21 Sep 2022 14:05:07 +0000 (22:05 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 23 Sep 2022 02:30:34 +0000 (19:30 -0700)
Remove unnecessary set_drvdata(NULL) function in ->remove(),
the driver_data will be set to NULL in device_unbind_cleanup()
after calling ->remove().

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/b53/b53_mdio.c
drivers/net/dsa/b53/b53_mmap.c
drivers/net/dsa/b53/b53_srab.c

index a7aeb3c132c987297239c178fa0f7e69ea701df2..6ddc03b58b28b6903dc83972cc3311742bf90c1b 100644 (file)
@@ -356,8 +356,6 @@ static void b53_mdio_remove(struct mdio_device *mdiodev)
                return;
 
        b53_switch_remove(dev);
-
-       dev_set_drvdata(&mdiodev->dev, NULL);
 }
 
 static void b53_mdio_shutdown(struct mdio_device *mdiodev)
index ae4c79d39bc047e8274cc849078a960df1545527..e968322dfbf0b262e23cd55fa482d5eb268fd2dc 100644 (file)
@@ -316,8 +316,6 @@ static int b53_mmap_remove(struct platform_device *pdev)
        if (dev)
                b53_switch_remove(dev);
 
-       platform_set_drvdata(pdev, NULL);
-
        return 0;
 }
 
index da0b889880f6af57dd4ed4189e06efb68ee003b5..bcb44034404d390c05b566e090d0adf52e88c3fa 100644 (file)
@@ -667,8 +667,6 @@ static int b53_srab_remove(struct platform_device *pdev)
        b53_srab_intr_set(dev->priv, false);
        b53_switch_remove(dev);
 
-       platform_set_drvdata(pdev, NULL);
-
        return 0;
 }