btrfs: introduce BTRFS_RESERVE_FLUSH_EMERGENCY

Inside of FB, as well as some user reports, we've had a consistent
problem of occasional ENOSPC transaction aborts.  Inside FB we were
seeing ~100-200 ENOSPC aborts per day in the fleet, which is a really
low occurrence rate given the size of our fleet, but it's not nothing.

There are two causes of this particular problem.

First is delayed allocation.  The reservation system for delalloc
assumes that contiguous dirty ranges will result in 1 file extent item.
However if there is memory pressure that results in fragmented writeout,
or there is fragmentation in the block groups, this won't necessarily be
true.  Consider the case where we do a single 256MiB write to a file and
then close it.  We will have 1 reservation for the inode update, the
reservations for the checksum updates, and 1 reservation for the file
extent item.  At some point later we decide to write this entire range
out, but we're so fragmented that we break this into 100 different file
extents.  Since we've already closed the file and are no longer writing
to it there's nothing to trigger a refill of the delalloc block rsv to
satisfy the 99 new file extent reservations we need.  At this point we
exhaust our delalloc reservation, and we begin to steal from the global
reserve.  If you have enough of these cases going in parallel you can
easily exhaust the global reserve, get an ENOSPC at
btrfs_alloc_tree_block() time, and then abort the transaction.

The other case is the delayed refs reserve.  The delayed refs reserve
updates its size based on outstanding delayed refs and dirty block
groups.  However we only refill this block reserve when returning
excess reservations and when we call btrfs_start_transaction(root, X).
We will reserve 2*X credits at transaction start time, and fill in X
into the delayed refs reserve to make sure it stays topped off.
Generally this works well, but clearly has downsides.  If we do a
particularly delayed ref heavy operation we may never catch up in our
reservations.  Additionally running delayed refs generates more delayed
refs, and at that point we may be committing the transaction and have no
way to trigger a refill of our delayed refs rsv.  Then a similar thing
occurs with the delalloc reserve.

Generally speaking we well over-reserve in all of our block rsvs.  If we
reserve 1 credit we're usually reserving around 264k of space, but we'll
often not use any of that reservation, or use a few blocks of that
reservation.  We can be reasonably sure that as long as you were able to
reserve space up front for your operation you'll be able to find space
on disk for that reservation.

So introduce a new flushing state, BTRFS_RESERVE_FLUSH_EMERGENCY.  This
gets used in the case that we've exhausted our reserve and the global
reserve.  It simply forces a reservation if we have enough actual space
on disk to make the reservation, which is almost always the case.  This
keeps us from hitting ENOSPC aborts in these odd occurrences where we've
not kept up with the delayed work.

Fixing this in a complete way is going to be relatively complicated and
time consuming.  This patch is what I discussed with Filipe earlier this
year, and what I put into our kernels inside FB.  With this patch we're
down to 1-2 ENOSPC aborts per week, which is a significant reduction.
This is a decent stop gap until we can work out a more wholistic
solution to these two corner cases.

Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: David Sterba <dsterba@suse.com>

diff --git a/fs/btrfs/block-rsv.c b/fs/btrfs/block-rsv.c
index ec96285357e0a64c4abacf4650764b1c6dcba1c2..89e3e7d1bff63323722c4e55db86df6fdc6edfc1 100644 (file)
--- a/fs/btrfs/block-rsv.c
+++ b/fs/btrfs/block-rsv.c
@@ -552,5 +552,17 @@ try_reserve:
                if (!ret)
                        return global_rsv;
        }
+
+       /*
+        * All hope is lost, but of course our reservations are overly
+        * pessimistic, so instead of possibly having an ENOSPC abort here, try
+        * one last time to force a reservation if there's enough actual space
+        * on disk to make the reservation.
+        */
+       ret = btrfs_reserve_metadata_bytes(fs_info, block_rsv, blocksize,
+                                          BTRFS_RESERVE_FLUSH_EMERGENCY);
+       if (!ret)
+               return block_rsv;
+
        return ERR_PTR(ret);
 }

diff --git a/fs/btrfs/space-info.c b/fs/btrfs/space-info.c
index f171bf8756336453118155f6948adfaf152d8365..af2e133aaa5c0924a085c75d4d0d9b2466b38d43 100644 (file)
--- a/fs/btrfs/space-info.c
+++ b/fs/btrfs/space-info.c
@@ -1583,6 +1583,16 @@ static inline bool can_steal(enum btrfs_reserve_flush_enum flush)
                flush == BTRFS_RESERVE_FLUSH_EVICT);
 }
 
+/*
+ * NO_FLUSH and FLUSH_EMERGENCY don't want to create a ticket, they just want to
+ * fail as quickly as possible.
+ */
+static inline bool can_ticket(enum btrfs_reserve_flush_enum flush)
+{
+       return (flush != BTRFS_RESERVE_NO_FLUSH &&
+               flush != BTRFS_RESERVE_FLUSH_EMERGENCY);
+}
+
 /**
  * Try to reserve bytes from the block_rsv's space
  *
@@ -1644,6 +1654,21 @@ static int __reserve_bytes(struct btrfs_fs_info *fs_info,
                ret = 0;
        }
 
+       /*
+        * Things are dire, we need to make a reservation so we don't abort.  We
+        * will let this reservation go through as long as we have actual space
+        * left to allocate for the block.
+        */
+       if (ret && unlikely(flush == BTRFS_RESERVE_FLUSH_EMERGENCY)) {
+               used = btrfs_space_info_used(space_info, false);
+               if (used + orig_bytes <=
+                   writable_total_bytes(fs_info, space_info)) {
+                       btrfs_space_info_update_bytes_may_use(fs_info, space_info,
+                                                             orig_bytes);
+                       ret = 0;
+               }
+       }
+
        /*
         * If we couldn't make a reservation then setup our reservation ticket
         * and kick the async worker if it's not already running.
@@ -1651,7 +1676,7 @@ static int __reserve_bytes(struct btrfs_fs_info *fs_info,
         * If we are a priority flusher then we just need to add our ticket to
         * the list and we will do our own flushing further down.
         */
-       if (ret && flush != BTRFS_RESERVE_NO_FLUSH) {
+       if (ret && can_ticket(flush)) {
                ticket.bytes = orig_bytes;
                ticket.error = 0;
                space_info->reclaim_size += ticket.bytes;
@@ -1701,7 +1726,7 @@ static int __reserve_bytes(struct btrfs_fs_info *fs_info,
                }
        }
        spin_unlock(&space_info->lock);
-       if (!ret || flush == BTRFS_RESERVE_NO_FLUSH)
+       if (!ret || !can_ticket(flush))
                return ret;
 
        return handle_reserve_ticket(fs_info, space_info, &ticket, start_ns,

diff --git a/fs/btrfs/space-info.h b/fs/btrfs/space-info.h
index 7e17bb80343608b65a817b33aabec76fe91256d7..f28bd2c051d497c870c8c5a4e7660009c2811cea 100644 (file)
--- a/fs/btrfs/space-info.h
+++ b/fs/btrfs/space-info.h
@@ -48,6 +48,24 @@ enum btrfs_reserve_flush_enum {
         * Can be interrupted by a fatal signal.
         */
        BTRFS_RESERVE_FLUSH_ALL_STEAL,
+
+       /*
+        * This is for btrfs_use_block_rsv only.  We have exhausted our block
+        * rsv and our global block rsv.  This can happen for things like
+        * delalloc where we are overwriting a lot of extents with a single
+        * extent and didn't reserve enough space.  Alternatively it can happen
+        * with delalloc where we reserve 1 extents worth for a large extent but
+        * fragmentation leads to multiple extents being created.  This will
+        * give us the reservation in the case of
+        *
+        * if (num_bytes < (space_info->total_bytes -
+        *                  btrfs_space_info_used(space_info, false))
+        *
+        * Which ignores bytes_may_use.  This is potentially dangerous, but our
+        * reservation system is generally pessimistic so is able to absorb this
+        * style of mistake.
+        */
+       BTRFS_RESERVE_FLUSH_EMERGENCY,
 };
 
 enum btrfs_flush_state {