sparc: switch to providing csum_and_copy_from_user()
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 18 Feb 2020 18:07:41 +0000 (13:07 -0500)
committerAl Viro <viro@zeniv.linux.org.uk>
Fri, 29 May 2020 20:11:49 +0000 (16:11 -0400)
sparc64 already is equivalent to that (trivial access_ok());
add it into sparc32 csum_partial_copy_from_user() and we can
rename both to csum_and_copy_fromUser() and be done with that.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
arch/sparc/include/asm/checksum.h
arch/sparc/include/asm/checksum_32.h
arch/sparc/include/asm/checksum_64.h

index c3be56e2e768a775456b3defab331380f1324a8c..a6256cb6fc5cc451ce54ba4944416c7d034eacda 100644 (file)
@@ -1,6 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 #ifndef ___ASM_SPARC_CHECKSUM_H
 #define ___ASM_SPARC_CHECKSUM_H
+#define _HAVE_ARCH_COPY_AND_CSUM_FROM_USER
 #if defined(__sparc__) && defined(__arch64__)
 #include <asm/checksum_64.h>
 #else
index 450ddfb444c879d617e414b12a51c63ca62c2158..479a0b812af50a59ada387e54fc1f697cfe068ff 100644 (file)
@@ -60,7 +60,7 @@ csum_partial_copy_nocheck(const void *src, void *dst, int len, __wsum sum)
 }
 
 static inline __wsum
-csum_partial_copy_from_user(const void __user *src, void *dst, int len,
+csum_and_copy_from_user(const void __user *src, void *dst, int len,
                            __wsum sum, int *err)
   {
        register unsigned long ret asm("o0") = (unsigned long)src;
@@ -68,6 +68,12 @@ csum_partial_copy_from_user(const void __user *src, void *dst, int len,
        register int l asm("g1") = len;
        register __wsum s asm("g7") = sum;
 
+       if (unlikely(!access_ok(src, len))) {
+               if (len)
+                       *err = -EFAULT;
+               return sum;
+       }
+
        __asm__ __volatile__ (
        ".section __ex_table,#alloc\n\t"
        ".align 4\n\t"
index e52450930e4eacebb9c20cb3c4145320c7ddcc1b..0fa4433f5662ba77309957e0ae28ae7bc6b64a23 100644 (file)
@@ -46,7 +46,7 @@ long __csum_partial_copy_from_user(const void __user *src,
                                   __wsum sum);
 
 static inline __wsum
-csum_partial_copy_from_user(const void __user *src,
+csum_and_copy_from_user(const void __user *src,
                            void *dst, int len,
                            __wsum sum, int *err)
 {