staging: r8188eu: remove the "dump rx packet" fragments

Remove the code fragments for printing incoming packets. There's only a
hal variable HAL_DEF_DBG_DUMP_RXPKT and the bDumpRxPkt component of
struct hal_data_8188e.

The hal variable is set by a private ioctl, it's read in
validate_recv_frame but it's not used.

All of this can be removed, there's no code to dump the packets.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220330201210.175941-2-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c
index 62cf2df90073645397f15a1c0b2a4cf20f45495c..476bd4f225289095e9eed019b8fe20b88b080337 100644 (file)
--- a/drivers/staging/r8188eu/core/rtw_recv.c
+++ b/drivers/staging/r8188eu/core/rtw_recv.c
@@ -1060,7 +1060,6 @@ static int validate_recv_frame(struct adapter *adapter, struct recv_frame *precv
        /* then call check if rx seq/frag. duplicated. */
 
        int retval = _FAIL;
-       u8 bDumpRxPkt;
        struct rx_pkt_attrib *pattrib = &precv_frame->attrib;
        u8 *ptr = precv_frame->rx_data;
        struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)precv_frame->rx_data;
@@ -1086,9 +1085,6 @@ static int validate_recv_frame(struct adapter *adapter, struct recv_frame *precv
        pattrib->privacy = ieee80211_has_protected(hdr->frame_control);
        pattrib->order = ieee80211_has_order(hdr->frame_control);
 
-       /* Dump rx packets */
-       GetHalDefVar8188EUsb(adapter, HAL_DEF_DBG_DUMP_RXPKT, &bDumpRxPkt);
-
        /* We return _SUCCESS only for data frames. */
        if (ieee80211_is_mgmt(hdr->frame_control))
                validate_recv_mgnt_frame(adapter, precv_frame);

diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
index e558505b22ba49c54b0c1442a29c500a2c9cf48b..5c6206165c6a1f18c9e7bc8784eb6df9a9872ff5 100644 (file)
--- a/drivers/staging/r8188eu/hal/usb_halinit.c
+++ b/drivers/staging/r8188eu/hal/usb_halinit.c
@@ -1338,9 +1338,6 @@ void GetHalDefVar8188EUsb(struct adapter *Adapter, enum hal_def_variable eVariab
        case HAL_DEF_DBG_DM_FUNC:
                *((u32 *)pValue) = haldata->odmpriv.SupportAbility;
                break;
-       case HAL_DEF_DBG_DUMP_RXPKT:
-               *((u8 *)pValue) = haldata->bDumpRxPkt;
-               break;
        case HAL_DEF_DBG_DUMP_TXPKT:
                *((u8 *)pValue) = haldata->bDumpTxPkt;
                break;
@@ -1373,9 +1370,6 @@ void SetHalDefVar8188EUsb(struct adapter *Adapter, enum hal_def_variable eVariab
                        }
                }
                break;
-       case HAL_DEF_DBG_DUMP_RXPKT:
-               haldata->bDumpRxPkt = *((u8 *)pValue);
-               break;
        case HAL_DEF_DBG_DUMP_TXPKT:
                haldata->bDumpTxPkt = *((u8 *)pValue);
                break;

diff --git a/drivers/staging/r8188eu/include/hal_intf.h b/drivers/staging/r8188eu/include/hal_intf.h
index a997bbbae69fb7a9f2a3c301446a80d90a6f938a..3ac8b2e0476c0d071ee60c2d69cd1fdda7b84948 100644 (file)
--- a/drivers/staging/r8188eu/include/hal_intf.h
+++ b/drivers/staging/r8188eu/include/hal_intf.h
@@ -40,7 +40,6 @@ enum hw_variables {
 enum hal_def_variable {
        HAL_DEF_IS_SUPPORT_ANT_DIV,
        HAL_DEF_CURRENT_ANTENNA,
-       HAL_DEF_DBG_DUMP_RXPKT,/* for dbg */
        HAL_DEF_DBG_DM_FUNC,/* for dbg */
        HAL_DEF_DBG_DUMP_TXPKT,
 };

diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
index 82cb4f7f4d3ec2c7a9e4b37b4472495914711947..5bda353b6a412faf09ef666e68efe63be1645493 100644 (file)
--- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
+++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
@@ -160,7 +160,6 @@ struct hal_data_8188e {
        u8      AntDivCfg;
        u8      TRxAntDivType;
 
-       u8      bDumpRxPkt;/* for debug */
        u8      bDumpTxPkt;/* for debug */
 
        u8      OutEpQueueSel;

diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
index eb9375b0c6606216c42cff2f40f00ff8a7271049..a45d60a7c19b7ddd1f4188ddd732a976b42317ed 100644 (file)
--- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c
+++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
@@ -3633,11 +3633,8 @@ static int rtw_dbg_port(struct net_device *dev,
                case 0x09:
                        break;
                case 0x0c:/* dump rx/tx packet */
-                       if (arg == 0) {
-                               SetHalDefVar8188EUsb(padapter, HAL_DEF_DBG_DUMP_RXPKT, &extra_arg);
-                       } else if (arg == 1) {
+                       if (arg == 1)
                                SetHalDefVar8188EUsb(padapter, HAL_DEF_DBG_DUMP_TXPKT, &extra_arg);
-                       }
                        break;
                case 0x15:
                        break;