hw/intc: Pass correct hartid while updating mtimecmp
authorAtish Patra <atishp@rivosinc.com>
Fri, 13 May 2022 22:14:58 +0000 (15:14 -0700)
committerAlistair Francis <alistair.francis@wdc.com>
Mon, 23 May 2022 23:48:20 +0000 (09:48 +1000)
timecmp update function should be invoked with hartid for which
timecmp is being updated. The following patch passes the incorrect
hartid to the update function.

Fixes: e2f01f3c2e13 ("hw/intc: Make RISC-V ACLINT mtime MMIO register writable")
Signed-off-by: Atish Patra <atishp@rivosinc.com>
Reviewed-by: Frank Chang <frank.chang@sifive.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20220513221458.1192933-1-atishp@rivosinc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
hw/intc/riscv_aclint.c

index 0412edc982575dd21e90302f33eb7ef5f3b6672b..e6bceceefdbc09aa7a8a57da237c78d4231a9a05 100644 (file)
@@ -233,7 +233,8 @@ static void riscv_aclint_mtimer_write(void *opaque, hwaddr addr,
                 continue;
             }
             riscv_aclint_mtimer_write_timecmp(mtimer, RISCV_CPU(cpu),
-                                              i, env->timecmp);
+                                              mtimer->hartid_base + i,
+                                              env->timecmp);
         }
         return;
     }