staging: vt6655: Convert macro vt6655_mac_word_reg_bits_on to function
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Wed, 13 Jul 2022 05:01:37 +0000 (07:01 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 14 Jul 2022 13:48:38 +0000 (15:48 +0200)
Convert macro vt6655_mac_word_reg_bits_on to function.
checkpatch.pl does not accept multiline macros.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/255c7f5a5e98a399aa4e299e7cf567016bd86d60.1657657918.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6655/mac.c
drivers/staging/vt6655/mac.h

index 902034a28c6c9624b03714af0abf013f7f1df4a2..076e1bfff3e0f31ab74a28940c973796e3dfce8e 100644 (file)
@@ -46,6 +46,14 @@ void vt6655_mac_reg_bits_on(void __iomem *iobase, const u8 reg_offset, const u8
        iowrite8(reg_value | bit_mask, iobase + reg_offset);
 }
 
+void vt6655_mac_word_reg_bits_on(void __iomem *iobase, const u8 reg_offset, const u16 bit_mask)
+{
+       unsigned short reg_value;
+
+       reg_value = ioread16(iobase + reg_offset);
+       iowrite16(reg_value | (bit_mask), iobase + reg_offset);
+}
+
 /*
  * Description:
  *      Test if all test bits off
index 031316d42dba482d23d8f349b33486407a6b708e..3b23334db5380d813e8ea915c7a40f9b1b1f115f 100644 (file)
 
 /*---------------------  Export Macros ------------------------------*/
 
-#define vt6655_mac_word_reg_bits_on(iobase, reg_offset, bit_mask)      \
-do {                                                                   \
-       unsigned short reg_value;                                       \
-       reg_value = ioread16(iobase + reg_offset);                      \
-       iowrite16(reg_value | (bit_mask), iobase + reg_offset);         \
-} while (0)
-
 #define vt6655_mac_reg_bits_off(iobase, reg_offset, bit_mask)                  \
 do {                                                                   \
        unsigned char reg_value;                                        \
@@ -660,6 +653,7 @@ do {                                                                        \
        ((unsigned short)(((unsigned char)(lb)) | (((unsigned short)((unsigned char)(hb))) << 8)))
 
 void vt6655_mac_reg_bits_on(void __iomem *iobase, const u8 reg_offset, const u8 bit_mask);
+void vt6655_mac_word_reg_bits_on(void __iomem *iobase, const u8 reg_offset, const u16 bit_mask);
 bool MACbIsRegBitsOff(struct vnt_private *priv, unsigned char byRegOfs,
                      unsigned char byTestBits);