serial: liteuart: rx loop should only ack rx events

While receiving characters, it is necessary to acknowledge each one
by writing to the EV_PENDING register's EV_RX bit. Ensure we do not
also gratuitously set the EV_TX bit in the process.

Signed-off-by: Gabriel Somlo <gsomlo@gmail.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20221123130500.1030189-8-gsomlo@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
index 81a86c5eb3937720eb2aa14f1839432017cdf033..c90ab65fbdcfbec307f5c0152f41dff7eb3bf8b9 100644 (file)
--- a/drivers/tty/serial/liteuart.c
+++ b/drivers/tty/serial/liteuart.c
@@ -82,7 +82,7 @@ static void liteuart_timer(struct timer_list *t)
                port->icount.rx++;
 
                /* necessary for RXEMPTY to refresh its value */
-               litex_write8(membase + OFF_EV_PENDING, EV_TX | EV_RX);
+               litex_write8(membase + OFF_EV_PENDING, EV_RX);
 
                /* no overflow bits in status */
                if (!(uart_handle_sysrq_char(port, ch)))