mm/damon/dbgfs: rename monitor_on file to monitor_on_DEPRECATED
authorSeongJae Park <sj@kernel.org>
Tue, 30 Jan 2024 01:35:46 +0000 (17:35 -0800)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 22 Feb 2024 18:24:46 +0000 (10:24 -0800)
Kernel builders could silently enable CONFIG_DAMON_DBGFS_DEPRECATED.
Users who manually check the files under the DAMON debugfs directory could
notice the deprecation owing to the 'DEPRECATED' DAMON debugfs file, but
there could be users who doesn't manually check the files.

Make the deprecation cannot be ignored in the case by renaming
'monitor_on' file, which is essential for real use of DAMON on runtime, to
'monitor_on_DEPRECATED'.  Still users who control DAMON via only
user-space tool could ignore the deprecation, but that's what the tool
developers should take care of.  DAMON user-space tool, damo, has also
made a change[1] for the purpose.

[1] commit 935dae76f2aee ("_damon_args: Rename --damon_interface to
    --damon_interface_DEPRECATED") of https://github.com/awslabs/damo

Link: https://lkml.kernel.org/r/20240130013549.89538-8-sj@kernel.org
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Alex Shi <alexs@kernel.org>
Cc: Hu Haowen <2023002089@link.tyut.edu.cn>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Yanteng Si <siyanteng@loongson.cn>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/dbgfs.c

index 45d769984daa38dd54db175432a55057ebe946ac..2461cfe2e968833dd67103687ac6bc51a935a0b5 100644 (file)
@@ -1090,7 +1090,7 @@ static int __init __damon_dbgfs_init(void)
 {
        struct dentry *dbgfs_root;
        const char * const file_names[] = {"mk_contexts", "rm_contexts",
-               "monitor_on", "DEPRECATED"};
+               "monitor_on_DEPRECATED", "DEPRECATED"};
        const struct file_operations *fops[] = {&mk_contexts_fops,
                &rm_contexts_fops, &monitor_on_fops, &deprecated_fops};
        int i;