drm/i915: Don't include intel_de.h from intel_display_types.h
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 30 Apr 2021 14:39:44 +0000 (17:39 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 5 May 2021 18:04:42 +0000 (21:04 +0300)
Hoist the intel_de.h include from intel_display_types.h one
level up. I need this in order to untangle the include order
so that I can add tracepoints into intel_de.h.

This little cocci script did most of the work for me:
@find@
@@
(
intel_de_read(...)
|
intel_de_read_fw(...)
|
intel_de_write(...)
|
intel_de_write_fw(...)
)

@has_include@
@@
(
 #include "intel_de.h"
|
 #include "display/intel_de.h"
)

@depends on find && !has_include@
@@
+ #include "intel_de.h"
  #include "intel_display_types.h"

@depends on find && !has_include@
@@
+ #include "display/intel_de.h"
  #include "display/intel_display_types.h"

Cc: Cooper Chiou <cooper.chiou@intel.com>
Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210430143945.6776-1-ville.syrjala@linux.intel.com
48 files changed:
drivers/gpu/drm/i915/display/g4x_dp.c
drivers/gpu/drm/i915/display/g4x_hdmi.c
drivers/gpu/drm/i915/display/i9xx_plane.c
drivers/gpu/drm/i915/display/icl_dsi.c
drivers/gpu/drm/i915/display/intel_audio.c
drivers/gpu/drm/i915/display/intel_cdclk.c
drivers/gpu/drm/i915/display/intel_color.c
drivers/gpu/drm/i915/display/intel_combo_phy.c
drivers/gpu/drm/i915/display/intel_crt.c
drivers/gpu/drm/i915/display/intel_cursor.c
drivers/gpu/drm/i915/display/intel_ddi.c
drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
drivers/gpu/drm/i915/display/intel_display.c
drivers/gpu/drm/i915/display/intel_display_debugfs.c
drivers/gpu/drm/i915/display/intel_display_power.c
drivers/gpu/drm/i915/display/intel_display_types.h
drivers/gpu/drm/i915/display/intel_dp.c
drivers/gpu/drm/i915/display/intel_dp_hdcp.c
drivers/gpu/drm/i915/display/intel_dp_mst.c
drivers/gpu/drm/i915/display/intel_dpio_phy.c
drivers/gpu/drm/i915/display/intel_dpll.c
drivers/gpu/drm/i915/display/intel_dpll_mgr.c
drivers/gpu/drm/i915/display/intel_dsb.c
drivers/gpu/drm/i915/display/intel_dvo.c
drivers/gpu/drm/i915/display/intel_fbc.c
drivers/gpu/drm/i915/display/intel_fdi.c
drivers/gpu/drm/i915/display/intel_fifo_underrun.c
drivers/gpu/drm/i915/display/intel_gmbus.c
drivers/gpu/drm/i915/display/intel_hdcp.c
drivers/gpu/drm/i915/display/intel_hdmi.c
drivers/gpu/drm/i915/display/intel_lspcon.c
drivers/gpu/drm/i915/display/intel_lvds.c
drivers/gpu/drm/i915/display/intel_overlay.c
drivers/gpu/drm/i915/display/intel_panel.c
drivers/gpu/drm/i915/display/intel_pipe_crc.c
drivers/gpu/drm/i915/display/intel_pps.c
drivers/gpu/drm/i915/display/intel_psr.c
drivers/gpu/drm/i915/display/intel_sdvo.c
drivers/gpu/drm/i915/display/intel_sprite.c
drivers/gpu/drm/i915/display/intel_tv.c
drivers/gpu/drm/i915/display/intel_vdsc.c
drivers/gpu/drm/i915/display/intel_vrr.c
drivers/gpu/drm/i915/display/skl_scaler.c
drivers/gpu/drm/i915/display/skl_universal_plane.c
drivers/gpu/drm/i915/display/vlv_dsi.c
drivers/gpu/drm/i915/display/vlv_dsi_pll.c
drivers/gpu/drm/i915/i915_irq.c
drivers/gpu/drm/i915/intel_pm.c

index dfe3cf328d134a3acd153862934ab9e06521f97e..de0f358184aa337f49c11f1ea865182f80b5d6f1 100644 (file)
@@ -8,6 +8,7 @@
 #include "g4x_dp.h"
 #include "intel_audio.h"
 #include "intel_connector.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dp_link_training.h"
index 78f93506ffaf9503ca9c6c1fb46ca89ec7f86283..be352e9f0afc1aed2dfe8d00364d19634ed722c9 100644 (file)
@@ -8,6 +8,7 @@
 #include "g4x_hdmi.h"
 #include "intel_audio.h"
 #include "intel_connector.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dpio_phy.h"
 #include "intel_fifo_underrun.h"
index 393ef09ba0ace3cd94f4603910c2d24b9d45b85b..9643c45a220965abee08f82e11b5461e8a3f8096 100644 (file)
@@ -10,6 +10,7 @@
 
 #include "intel_atomic.h"
 #include "intel_atomic_plane.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_fb.h"
 #include "intel_sprite.h"
index 781630a40f06698dd4e5ae10961d0cda77f57465..ce544e20f35c40d871dec766d1584d4f04aa4bb3 100644 (file)
@@ -33,6 +33,7 @@
 #include "intel_connector.h"
 #include "intel_crtc.h"
 #include "intel_ddi.h"
+#include "intel_de.h"
 #include "intel_dsi.h"
 #include "intel_panel.h"
 #include "intel_vdsc.h"
index 75871ee544a7f3303cfcd4cebb3da89ed354ca1a..5f4f316b3ab5ce48a57ced93d3b9e64bb8e86484 100644 (file)
@@ -31,6 +31,7 @@
 #include "intel_atomic.h"
 #include "intel_audio.h"
 #include "intel_cdclk.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_lpe_audio.h"
 
index 1f0bd23bb883363c88699c3d6691487f009fe805..f95896f7c113d052df0a361539f27fb18b486fb3 100644 (file)
@@ -26,6 +26,7 @@
 #include "intel_atomic.h"
 #include "intel_bw.h"
 #include "intel_cdclk.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_sideband.h"
 
index 5fae69879adf418690f59764195eda8f145656bb..dab892d2251ba4d5199faa9033444f957b6c2840 100644 (file)
@@ -23,6 +23,7 @@
  */
 
 #include "intel_color.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 
 #define CTM_COEFF_SIGN (1ULL << 63)
index 5df57d16a4011d7371e4f403747c16166085ca40..487c54cd5982007d38c3e2867b79ce1a9506ab20 100644 (file)
@@ -4,6 +4,7 @@
  */
 
 #include "intel_combo_phy.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 
 #define for_each_combo_phy(__dev_priv, __phy) \
index 1aac8bead4eb778964262c6a36fd2c34a455f025..648f1c0d3d39f760e214ccf616a301ea3624a45e 100644 (file)
@@ -38,6 +38,7 @@
 #include "intel_crt.h"
 #include "intel_crtc.h"
 #include "intel_ddi.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_fdi.h"
 #include "intel_fifo_underrun.h"
index 2345f2efd60b85abe1189ae922008064b847614e..2ab389b386940d23c2f95ea9495c5aeee1d57d5a 100644 (file)
@@ -13,6 +13,7 @@
 #include "intel_atomic.h"
 #include "intel_atomic_plane.h"
 #include "intel_cursor.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_display.h"
 #include "intel_fb.h"
index 93d94d50b63dbe151d0da9f5c9662a53edc2a1d8..0b382e40d594a8ad5b10a0422af47afce704e472 100644 (file)
@@ -34,6 +34,7 @@
 #include "intel_crtc.h"
 #include "intel_ddi.h"
 #include "intel_ddi_buf_trans.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dp_link_training.h"
index 58d6417b8f3e2ff1501388b59b8fb0b5789ca0f2..7bcdd5c120288954f1ac364a4abf941d1dd52c60 100644 (file)
@@ -6,6 +6,7 @@
 #include "i915_drv.h"
 #include "intel_ddi.h"
 #include "intel_ddi_buf_trans.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 
 /* HDMI/DVI modes ignore everything but the last 2 items. So we share
index cc673bb63941baa3d6c38b9451678c2755e9f156..72c548d7e00d0ae11c688af37b88c5d39238c3c2 100644 (file)
@@ -78,6 +78,7 @@
 #include "intel_color.h"
 #include "intel_crtc.h"
 #include "intel_csr.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dp_link_training.h"
 #include "intel_fbc.h"
index 183c414d554a18b931b61fbf1310fd2b0f8b1ef0..d55ae83d037a87a041c992cc1c0a0a57c8a99d56 100644 (file)
@@ -10,6 +10,7 @@
 #include "intel_csr.h"
 #include "intel_display_debugfs.h"
 #include "intel_display_power.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_fbc.h"
index d48dd15a4f6e74f56f6566409b83fae4ef6917a4..653744d831af729aac4e9ff9c395733ad1be79bb 100644 (file)
@@ -11,6 +11,7 @@
 #include "intel_combo_phy.h"
 #include "intel_csr.h"
 #include "intel_display_power.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dpio_phy.h"
 #include "intel_hotplug.h"
index e2e707c4dff56fcf5541fa274c86f4048c0a7dac..6d8cdaa3674855a259926c2453dca25a5752f860 100644 (file)
@@ -45,7 +45,6 @@
 #include <media/cec-notifier.h>
 
 #include "i915_drv.h"
-#include "intel_de.h"
 
 struct drm_printer;
 struct __intel_global_objs_state;
index dfa7da928ae50893c5b408d0fe24e581101243bc..cbbba8e33b2458023654f0ef52e16a3acbbcbd40 100644 (file)
@@ -46,6 +46,7 @@
 #include "intel_audio.h"
 #include "intel_connector.h"
 #include "intel_ddi.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dp_aux.h"
index d7c3a74b81a399801bb5c93dfb4be74ea58fa7bf..d697d169e8c1381f5d92e5663792502c082d9580 100644 (file)
@@ -12,6 +12,7 @@
 #include <drm/drm_print.h>
 
 #include "intel_ddi.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dp_hdcp.h"
index a30ca4380a06023e2970dd822ee94dede8ccf228..5f770fd53f1dcecc1623fbd8f08297a205289d7b 100644 (file)
@@ -34,6 +34,7 @@
 #include "intel_connector.h"
 #include "intel_crtc.h"
 #include "intel_ddi.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dp_hdcp.h"
index 514c4a7adffc8b7e364b9c5d6be33e343c616397..48507ed7995072201c67d88804c882f3860e0e34 100644 (file)
@@ -23,6 +23,7 @@
 
 #include "display/intel_dp.h"
 
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dpio_phy.h"
 #include "intel_sideband.h"
index 9114953f57f15083f9e023d15503894f9c4a155b..89635da9f6f6f288ff0d34e396993a926efbafc1 100644 (file)
@@ -4,6 +4,7 @@
  */
 #include <linux/kernel.h>
 #include "intel_crtc.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_display.h"
 #include "intel_dpll.h"
index da2ff0b3ceac195ea3acd69a008bbc7adcaec9fd..18bfe8d09277400ea512c8cc2ccc7ddbd4512a46 100644 (file)
@@ -21,6 +21,7 @@
  * DEALINGS IN THE SOFTWARE.
  */
 
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dpio_phy.h"
 #include "intel_dpll.h"
index 857126822a88bc58dee4571755492bcfa120b5b9..62a8a69f9f5d21251ddfb3a1e3732ce38be54869 100644 (file)
@@ -5,6 +5,7 @@
  */
 
 #include "i915_drv.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 
 #define DSB_BUF_SIZE    (2 * PAGE_SIZE)
index 090cd76266c6ead398ea15e2c78d442c292b55d0..77419f8c05e9f720f58bddd6bf931dbff95fe4a5 100644 (file)
@@ -33,6 +33,7 @@
 
 #include "i915_drv.h"
 #include "intel_connector.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dvo.h"
 #include "intel_dvo_dev.h"
index 91dad8004c3405c827fca1e0baba503b8af81994..b2f3ac846f5b6c4686aaee6110979e9ca5048a91 100644 (file)
@@ -43,6 +43,7 @@
 #include "i915_drv.h"
 #include "i915_trace.h"
 #include "i915_vgpu.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_fbc.h"
 #include "intel_frontbuffer.h"
index d719cd9c5b73ffabff57dcf6cca0e5ca69169440..cef1061fd6cb563baba358bf1c40a025ddd7f7be 100644 (file)
@@ -5,6 +5,7 @@
 #include "intel_atomic.h"
 #include "intel_ddi.h"
 #include "intel_ddi_buf_trans.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_fdi.h"
 
index 0fce9fd6e0a92e190f2833c0e488c004369016e5..3315aa1d4d5aad0811a567aaad3e034b8f6873f4 100644 (file)
@@ -27,6 +27,7 @@
 
 #include "i915_drv.h"
 #include "i915_trace.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_fbc.h"
 #include "intel_fifo_underrun.h"
index 17ab3cb81e0218d57d8738352f40623022fb58dc..fcf47f98ea365ef6add01c50f04dcfac101cc9eb 100644 (file)
@@ -34,6 +34,7 @@
 #include <drm/drm_hdcp.h>
 
 #include "i915_drv.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_gmbus.h"
 
index d254fe67ab7fa36675fa667c94447ebd73017319..ebc2e32aec0bc4b4b0ef387ce1f123bd07314243 100644 (file)
@@ -18,6 +18,7 @@
 #include "i915_drv.h"
 #include "i915_reg.h"
 #include "intel_display_power.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_hdcp.h"
 #include "intel_sideband.h"
index 47a8f0a1c5e28561cb5c9b52131c38f3ee463465..27bfa0bba77e406ceb690881fbe75176f7cb7333 100644 (file)
@@ -43,6 +43,7 @@
 #include "intel_atomic.h"
 #include "intel_connector.h"
 #include "intel_ddi.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_gmbus.h"
index e4ff533e3a69dc36d4ba7ea6df3247b3809cb6b2..328d31263357a9b96b5db4166489157f74a9449f 100644 (file)
@@ -27,6 +27,7 @@
 #include <drm/drm_dp_dual_mode_helper.h>
 #include <drm/drm_edid.h>
 
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_lspcon.h"
index dd12d15f47c70d5d0d5b2b6c3d2b86eb6a5ecc1c..7f40e9f60bc2b6879f19aedd78316f7e554830d8 100644 (file)
@@ -41,6 +41,7 @@
 #include "i915_drv.h"
 #include "intel_atomic.h"
 #include "intel_connector.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_gmbus.h"
 #include "intel_lvds.h"
index fffbde4256db1540d5f8e4cbcc5e9f67900b954f..83c25d84c391c376a57e558dfd4ea41111c5dd37 100644 (file)
@@ -34,6 +34,7 @@
 
 #include "i915_drv.h"
 #include "i915_reg.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_frontbuffer.h"
 #include "intel_overlay.h"
index a20761079ae0f9b7c5ece75b4157cfd3ca053c53..7d7a60b4d2de765192a71e9a3dceae765ca8e0c7 100644 (file)
@@ -35,6 +35,7 @@
 #include <linux/pwm.h>
 
 #include "intel_connector.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dp_aux_backlight.h"
 #include "intel_dsi_dcs_backlight.h"
index acc64b87d29fd5b8700067153f872bb40f6703ca..8ac263f471bee15f79ba138bb2fd0db214f2332f 100644 (file)
@@ -30,6 +30,7 @@
 #include <linux/seq_file.h>
 
 #include "intel_atomic.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_pipe_crc.h"
 
index 0fd28902d77997deb60dbb9a5e8865653a6959fd..a36ec4a818ff518fc6a9fb945f140676a08abf7a 100644 (file)
@@ -5,6 +5,7 @@
 
 #include "g4x_dp.h"
 #include "i915_drv.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dpll.h"
index c61e1d774667bdcd32ae49ef5293a61cf993dab0..e3c30dcadcd13f775af1bc658bc0b7186da8f909 100644 (file)
@@ -27,6 +27,7 @@
 
 #include "i915_drv.h"
 #include "intel_atomic.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dp_aux.h"
 #include "intel_hdmi.h"
index f6eb95c717d212a21b804d2c0420882eb3a591f6..e4f91d7a5c605800904af3d6bff8f9dfe6b10b07 100644 (file)
@@ -39,6 +39,7 @@
 #include "intel_atomic.h"
 #include "intel_connector.h"
 #include "intel_crtc.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_fifo_underrun.h"
 #include "intel_gmbus.h"
index acbf4e63b245bb4d3bd28d439a8f7016f9b0874b..4ae9a7455b2328eedcdce608ac11602439cb8701 100644 (file)
@@ -43,6 +43,7 @@
 #include "i915_trace.h"
 #include "i915_vgpu.h"
 #include "intel_atomic_plane.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_frontbuffer.h"
 #include "intel_sprite.h"
index 2c5c776934742d929ee508bcc4d3de89e0be7c57..ce73ebdfc66970882d8a504b7e8b720dd6e74170 100644 (file)
@@ -36,6 +36,7 @@
 
 #include "i915_drv.h"
 #include "intel_connector.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_hotplug.h"
 #include "intel_tv.h"
index 3a21c65ffa857a176a57c18df7844f1183b16758..42e3f9f7a37e9a20733c693093ab9dc0ccd1ec5a 100644 (file)
@@ -7,6 +7,7 @@
  */
 
 #include "i915_drv.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dsi.h"
 #include "intel_vdsc.h"
index a9c2b2fd92523b0faf5d7b6912773751d9092105..046210ae1de03cffbc3bb0758c2d00c7a783bdc8 100644 (file)
@@ -5,6 +5,7 @@
  */
 
 #include "i915_drv.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_vrr.h"
 
index 17a98cb627df453c4d2a09964d827217100347b3..394b7bbf48d824624567c8d7e8e56bf6883789e9 100644 (file)
@@ -2,6 +2,7 @@
 /*
  * Copyright © 2020 Intel Corporation
  */
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "skl_scaler.h"
 #include "skl_universal_plane.h"
index 553bc937ad90c6c4c5f0a1b7f8f783a62a09b972..0d34a5ad4e2b9fc7b29559eff3192a18ab5fd3c9 100644 (file)
@@ -10,6 +10,7 @@
 
 #include "i915_drv.h"
 #include "intel_atomic_plane.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_fb.h"
 #include "intel_pm.h"
index ac0553d492aa8bce591baccc59d7fcae043efb3d..084c9c43b2ed27d6500c71b7954967b18441b6b8 100644 (file)
@@ -34,6 +34,7 @@
 #include "intel_atomic.h"
 #include "intel_connector.h"
 #include "intel_crtc.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dsi.h"
 #include "intel_fifo_underrun.h"
index 4070b00c36909585336d24b62f5fdbb3f587a71b..90185b219447cb3f811ab91359eeefacb144b023 100644 (file)
@@ -28,6 +28,7 @@
 #include <linux/kernel.h>
 
 #include "i915_drv.h"
+#include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dsi.h"
 #include "intel_sideband.h"
index 798ecc718e3ff13f26b5ef31de8a768bfae284fc..f6967a93ec7ada7e7bb376197f0cf05b2d18bb2e 100644 (file)
@@ -35,6 +35,7 @@
 #include <drm/drm_drv.h>
 #include <drm/drm_irq.h>
 
+#include "display/intel_de.h"
 #include "display/intel_display_types.h"
 #include "display/intel_fifo_underrun.h"
 #include "display/intel_hotplug.h"
index cd584474d1e8e5ec8d7d3391509813555fb68a91..06d5b7cc8b62ad8d439da608b518cf4b78770144 100644 (file)
@@ -35,6 +35,7 @@
 #include "display/intel_atomic.h"
 #include "display/intel_atomic_plane.h"
 #include "display/intel_bw.h"
+#include "display/intel_de.h"
 #include "display/intel_display_types.h"
 #include "display/intel_fbc.h"
 #include "display/intel_sprite.h"