vnc-auth-sasl: Plug memleak in vnc_socket_ip_addr_string
authorPan Nengyuan <pannengyuan@huawei.com>
Mon, 31 Aug 2020 13:43:15 +0000 (09:43 -0400)
committerGerd Hoffmann <kraxel@redhat.com>
Fri, 4 Sep 2020 05:30:57 +0000 (07:30 +0200)
'addr' is forgot to free in vnc_socket_ip_addr_string error path. Fix that.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Message-Id: <20200831134315.1221-11-pannengyuan@huawei.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
ui/vnc-auth-sasl.c

index 7b2b09f2427639ebb3e1a327fdaeb327860d4d0a..0517b2ead9cee5d667432c6ac7816bc72268c9c1 100644 (file)
@@ -522,6 +522,7 @@ vnc_socket_ip_addr_string(QIOChannelSocket *ioc,
 
     if (addr->type != SOCKET_ADDRESS_TYPE_INET) {
         error_setg(errp, "Not an inet socket type");
+        qapi_free_SocketAddress(addr);
         return NULL;
     }
     ret = g_strdup_printf("%s;%s", addr->u.inet.host, addr->u.inet.port);