power: supply: mt6370: Fix missing error code in mt6370_chg_toggle_cfo()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Wed, 6 Sep 2023 08:48:15 +0000 (01:48 -0700)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Mon, 11 Sep 2023 18:15:43 +0000 (20:15 +0200)
When mt6370_chg_field_get() suceeds, ret is set to zero and returning
zero when flash led is still in strobe mode looks incorrect.

Fixes: 233cb8a47d65 ("power: supply: mt6370: Add MediaTek MT6370 charger driver")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: ChiaEn Wu <chiaen_wu@richtek.com>
Link: https://lore.kernel.org/r/20230906084815.2827930-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/mt6370-charger.c

index f27dae5043f5b41704b26a635db355eab5305ec7..a9641bd3d8cf8a413f9679dfb2ca9ee41ae45e75 100644 (file)
@@ -324,7 +324,7 @@ static int mt6370_chg_toggle_cfo(struct mt6370_priv *priv)
 
        if (fl_strobe) {
                dev_err(priv->dev, "Flash led is still in strobe mode\n");
-               return ret;
+               return -EINVAL;
        }
 
        /* cfo off */