serial: 8250_omap: Convert to use uart_xmit_advance()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 9 Sep 2022 09:12:58 +0000 (12:12 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 25 Sep 2022 07:27:38 +0000 (09:27 +0200)
uart_xmit_advance() provides a common way on how to advance
the Tx queue. Use it for the sake of unification and robustness.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20220909091258.68886-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_omap.c

index 85578b95c1ac1c37bbb24606c0464b6d28b1de07..871f8a05051305d7bf2fcfd9241a2597117a2921 100644 (file)
@@ -984,9 +984,7 @@ static void omap_8250_dma_tx_complete(void *param)
 
        dma->tx_running = 0;
 
-       xmit->tail += dma->tx_size;
-       xmit->tail &= UART_XMIT_SIZE - 1;
-       p->port.icount.tx += dma->tx_size;
+       uart_xmit_advance(&p->port, dma->tx_size);
 
        if (priv->delayed_restore) {
                priv->delayed_restore = 0;