s390/zcrypt: introduce retries on in-kernel send CPRB functions

The both functions zcrypt_send_cprb() and zcrypt_send_ep11_cprb()
are used to send CPRBs in-kernel from different sources. For
example the pkey module may call one of the functions in
zcrypt_ep11misc.c to trigger a derive of a protected key from
a secure key blob via an existing crypto card. These both
functions are then the internal API to send the CPRB and
receive the response.

All the ioctl functions to send an CPRB down to the addressed
crypto card use some kind of retry mechanism. When the first
attempt fails with ENODEV, a bus rescan is triggered and a
loop with retries is carried out.

For the both named internal functions there was never any
retry attempt made. This patch now introduces the retry code
even for this both internal functions to have effectively
same behavior on sending an CPRB from an in-kernel source
and sending an CPRB from userspace via ioctl.

Signed-off-by: Harald Freudenberger <freude@linux.ibm.com>
Reviewed-by: Holger Dengler <dengler@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>

diff --git a/drivers/s390/crypto/zcrypt_api.c b/drivers/s390/crypto/zcrypt_api.c
index 52990a8553e0b3b516264e571815c84b60d38521..56efaa63841fc1f42a1bf66a8ebe3bf3aeb47232 100644 (file)
--- a/drivers/s390/crypto/zcrypt_api.c
+++ b/drivers/s390/crypto/zcrypt_api.c
@@ -977,7 +977,26 @@ out:
 
 long zcrypt_send_cprb(struct ica_xcRB *xcrb)
 {
-       return _zcrypt_send_cprb(false, &ap_perms, NULL, xcrb);
+       struct zcrypt_track tr;
+       int rc;
+
+       memset(&tr, 0, sizeof(tr));
+
+       do {
+               rc = _zcrypt_send_cprb(false, &ap_perms, &tr, xcrb);
+       } while (rc == -EAGAIN && ++tr.again_counter < TRACK_AGAIN_MAX);
+
+       /* on ENODEV failure: retry once again after a requested rescan */
+       if (rc == -ENODEV && zcrypt_process_rescan())
+               do {
+                       rc = _zcrypt_send_cprb(false, &ap_perms, &tr, xcrb);
+               } while (rc == -EAGAIN && ++tr.again_counter < TRACK_AGAIN_MAX);
+       if (rc == -EAGAIN && tr.again_counter >= TRACK_AGAIN_MAX)
+               rc = -EIO;
+       if (rc)
+               pr_debug("%s rc=%d\n", __func__, rc);
+
+       return rc;
 }
 EXPORT_SYMBOL(zcrypt_send_cprb);
 
@@ -1162,7 +1181,26 @@ out:
 
 long zcrypt_send_ep11_cprb(struct ep11_urb *xcrb)
 {
-       return _zcrypt_send_ep11_cprb(false, &ap_perms, NULL, xcrb);
+       struct zcrypt_track tr;
+       int rc;
+
+       memset(&tr, 0, sizeof(tr));
+
+       do {
+               rc = _zcrypt_send_ep11_cprb(false, &ap_perms, &tr, xcrb);
+       } while (rc == -EAGAIN && ++tr.again_counter < TRACK_AGAIN_MAX);
+
+       /* on ENODEV failure: retry once again after a requested rescan */
+       if (rc == -ENODEV && zcrypt_process_rescan())
+               do {
+                       rc = _zcrypt_send_ep11_cprb(false, &ap_perms, &tr, xcrb);
+               } while (rc == -EAGAIN && ++tr.again_counter < TRACK_AGAIN_MAX);
+       if (rc == -EAGAIN && tr.again_counter >= TRACK_AGAIN_MAX)
+               rc = -EIO;
+       if (rc)
+               pr_debug("%s rc=%d\n", __func__, rc);
+
+       return rc;
 }
 EXPORT_SYMBOL(zcrypt_send_ep11_cprb);