ARM: dts: exynos: correct PMIC interrupt trigger level on Spring
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 10 Dec 2020 21:28:58 +0000 (22:28 +0100)
committerKrzysztof Kozlowski <krzk@kernel.org>
Tue, 29 Dec 2020 15:44:41 +0000 (16:44 +0100)
The Samsung PMIC datasheets describe the interrupt line as active low
with a requirement of acknowledge from the CPU.  Without specifying the
interrupt type in Devicetree, kernel might apply some fixed
configuration, not necessarily working for this hardware.

Fixes: 53dd4138bb0a ("ARM: dts: Add exynos5250-spring device tree")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201210212903.216728-4-krzk@kernel.org
arch/arm/boot/dts/exynos5250-spring.dts

index 9d2baea62d0d79ac58fa34d86cbd390e4fe71ea4..fba1462b19dfddbffe0faf07d4f7464e1ce124be 100644 (file)
                compatible = "samsung,s5m8767-pmic";
                reg = <0x66>;
                interrupt-parent = <&gpx3>;
-               interrupts = <2 IRQ_TYPE_NONE>;
+               interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
                pinctrl-names = "default";
                pinctrl-0 = <&s5m8767_irq &s5m8767_dvs &s5m8767_ds>;
                wakeup-source;