firmware: qcom_scm: Clear download bit during reboot
authorMukesh Ojha <quic_mojha@quicinc.com>
Thu, 16 Mar 2023 15:14:26 +0000 (20:44 +0530)
committerBjorn Andersson <andersson@kernel.org>
Mon, 20 Mar 2023 02:09:45 +0000 (19:09 -0700)
During normal restart of a system download bit should
be cleared irrespective of whether download mode is
set or not.

Fixes: 8c1b7dc9ba22 ("firmware: qcom: scm: Expose download-mode control")
Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/1678979666-551-1-git-send-email-quic_mojha@quicinc.com
drivers/firmware/qcom_scm.c

index b95616b35bffd0f6fc51425532403c7f0290a06f..ce76f5263aa393aa9c8ce97854294709931e98e7 100644 (file)
@@ -1508,8 +1508,7 @@ static int qcom_scm_probe(struct platform_device *pdev)
 static void qcom_scm_shutdown(struct platform_device *pdev)
 {
        /* Clean shutdown, disable download mode to allow normal restart */
-       if (download_mode)
-               qcom_scm_set_download_mode(false);
+       qcom_scm_set_download_mode(false);
 }
 
 static const struct of_device_id qcom_scm_dt_match[] = {