usb: cdns3: skip set TRB_IOC when usb_request: no_interrupt is true
authorFrank Li <Frank.Li@nxp.com>
Fri, 27 Oct 2023 18:39:19 +0000 (14:39 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Nov 2023 12:02:53 +0000 (12:02 +0000)
No completion irq is needed if no_interrupt is true. Needn't set TRB_IOC
at this case.

Check usb_request: no_interrupt and set/skip TRB_IOC in
cdns3_ep_run_transfer().

Signed-off-by: Frank Li <Frank.Li@nxp.com>
Acked-by: Peter Chen <peter.chen@kernel.org>
Link: https://lore.kernel.org/r/20231027183919.664271-1-Frank.Li@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/cdns3/cdns3-gadget.c

index 11a5b3437c32d2fe152743bf44c49ab1ce6142f7..15463b7cddd237c33a0722950da68dad8a75cac5 100644 (file)
@@ -1126,6 +1126,7 @@ static int cdns3_ep_run_transfer(struct cdns3_endpoint *priv_ep,
        u16 total_tdl = 0;
        struct scatterlist *s = NULL;
        bool sg_supported = !!(request->num_mapped_sgs);
+       u32 ioc = request->no_interrupt ? 0 : TRB_IOC;
 
        if (priv_ep->type == USB_ENDPOINT_XFER_ISOC)
                num_trb = priv_ep->interval;
@@ -1235,11 +1236,11 @@ static int cdns3_ep_run_transfer(struct cdns3_endpoint *priv_ep,
                        control |= pcs;
 
                if (priv_ep->type == USB_ENDPOINT_XFER_ISOC  && !priv_ep->dir) {
-                       control |= TRB_IOC | TRB_ISP;
+                       control |= ioc | TRB_ISP;
                } else {
                        /* for last element in TD or in SG list */
                        if (sg_iter == (num_trb - 1) && sg_iter != 0)
-                               control |= pcs | TRB_IOC | TRB_ISP;
+                               control |= pcs | ioc | TRB_ISP;
                }
 
                if (sg_iter)
@@ -1270,7 +1271,7 @@ static int cdns3_ep_run_transfer(struct cdns3_endpoint *priv_ep,
        priv_req->num_of_trb = num_trb;
 
        if (sg_iter == 1)
-               trb->control |= cpu_to_le32(TRB_IOC | TRB_ISP);
+               trb->control |= cpu_to_le32(ioc | TRB_ISP);
 
        if (priv_dev->dev_ver < DEV_VER_V2 &&
            (priv_ep->flags & EP_TDLCHK_EN)) {