platform/x86: sony-laptop: Remove useless comparisons in sony_pic_read_possible_resou...

Local variable 'p' is initialized by an address
of field of acpi_resource structure, so it does
not make sense to compare 'p' with NULL.

Local variable 'io' is initialized by an address
of field of acpi_resource structure, so it does
not make sense to compare 'io' with NULL.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Andrey Strachuk <strochuk@ispras.ru>
Link: https://lore.kernel.org/r/20220719110341.7239-1-strochuk@ispras.ru
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index d8d0c0bed5e91fdbe798e3820c67f5dbabb26ee6..07ef05f727a2c07b4d59314660cb2eadaf949f59 100644 (file)
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -4341,7 +4341,7 @@ sony_pic_read_possible_resource(struct acpi_resource *resource, void *context)
                {
                        struct acpi_resource_irq *p = &resource->data.irq;
                        struct sony_pic_irq *interrupt = NULL;
-                       if (!p || !p->interrupt_count) {
+                       if (!p->interrupt_count) {
                                /*
                                 * IRQ descriptors may have no IRQ# bits set,
                                 * particularly those those w/ _STA disabled
@@ -4374,11 +4374,6 @@ sony_pic_read_possible_resource(struct acpi_resource *resource, void *context)
                        struct acpi_resource_io *io = &resource->data.io;
                        struct sony_pic_ioport *ioport =
                                list_first_entry(&dev->ioports, struct sony_pic_ioport, list);
-                       if (!io) {
-                               dprintk("Blank IO resource\n");
-                               return AE_OK;
-                       }
-
                        if (!ioport->io1.minimum) {
                                memcpy(&ioport->io1, io, sizeof(*io));
                                dprintk("IO1 at 0x%.4x (0x%.2x)\n", ioport->io1.minimum,