ext4: remove unnecessary conditionals

iput() has already handled null and non-null parameter, so it is no
need to use if().

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Link: https://lore.kernel.org/r/20220411032337.2517465-1-lv.ruyi@zte.com.cn
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
index 7b0b57be86152217da98617120c24bd886ec3816..795a60ad18978451c2d5e19308fc9eaabd2ac5b3 100644 (file)
--- a/fs/ext4/fast_commit.c
+++ b/fs/ext4/fast_commit.c
@@ -1659,8 +1659,7 @@ static int ext4_fc_replay_create(struct super_block *sb, struct ext4_fc_tl *tl,
        set_nlink(inode, 1);
        ext4_mark_inode_dirty(NULL, inode);
 out:
-       if (inode)
-               iput(inode);
+       iput(inode);
        return ret;
 }
 

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 5675d3b38032455418abc5d8587742f9920a690a..dfe5514035c175eb53a1a0f934941cd1ce466c3c 100644 (file)
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -3363,8 +3363,7 @@ static int ext4_symlink(struct user_namespace *mnt_userns, struct inode *dir,
        err = ext4_add_nondir(handle, dentry, &inode);
        if (handle)
                ext4_journal_stop(handle);
-       if (inode)
-               iput(inode);
+       iput(inode);
        goto out_free_encrypted_link;
 
 err_drop_inode: