fpga: zynq: Switch to use dev_err_probe() helper

In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/20220926141729.2292311-1-yangyingliang@huawei.com
Signed-off-by: Xu Yilun <yilun.xu@intel.com>

diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
index 426aa34c6a0dcdc96a2a13caa6ee13613e7e6bec..ae0da361e6c6282448995155fa2aa6e8cd5f11be 100644 (file)
--- a/drivers/fpga/zynq-fpga.c
+++ b/drivers/fpga/zynq-fpga.c
@@ -582,11 +582,9 @@ static int zynq_fpga_probe(struct platform_device *pdev)
                return priv->irq;
 
        priv->clk = devm_clk_get(dev, "ref_clk");
-       if (IS_ERR(priv->clk)) {
-               if (PTR_ERR(priv->clk) != -EPROBE_DEFER)
-                       dev_err(dev, "input clock not found\n");
-               return PTR_ERR(priv->clk);
-       }
+       if (IS_ERR(priv->clk))
+               return dev_err_probe(dev, PTR_ERR(priv->clk),
+                                    "input clock not found\n");
 
        err = clk_prepare_enable(priv->clk);
        if (err) {