crypto: qat - drop input parameter from adf_enable_aer()
authorGiovanni Cabiddu <giovanni.cabiddu@intel.com>
Wed, 30 Sep 2020 22:22:11 +0000 (23:22 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 8 Oct 2020 05:38:06 +0000 (16:38 +1100)
Remove pointer to struct pci_driver from function adf_enable_aer() as it
is possible to get it directly from pdev->driver.

Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Reviewed-by: Fiona Trahe <fiona.trahe@intel.com>
Reviewed-by: Wojciech Ziemba <wojciech.ziemba@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/qat/qat_c3xxx/adf_drv.c
drivers/crypto/qat/qat_c62x/adf_drv.c
drivers/crypto/qat/qat_common/adf_aer.c
drivers/crypto/qat/qat_common/adf_common_drv.h
drivers/crypto/qat/qat_dh895xcc/adf_drv.c

index 6057dc9f15725e9807c5ca3073b3b5616391a3c5..ed0e8e33fe4b3d8e1458637d3f1a6edd28778c34 100644 (file)
@@ -198,7 +198,7 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        }
        pci_set_master(pdev);
 
-       if (adf_enable_aer(accel_dev, &adf_driver)) {
+       if (adf_enable_aer(accel_dev)) {
                dev_err(&pdev->dev, "Failed to enable aer\n");
                ret = -EFAULT;
                goto out_err_free_reg;
index ed4b3c2823808490332888fc058e5c23a3f742bf..d8e7c9c255903646bb1e7cd19a4be478988b31ba 100644 (file)
@@ -198,7 +198,7 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        }
        pci_set_master(pdev);
 
-       if (adf_enable_aer(accel_dev, &adf_driver)) {
+       if (adf_enable_aer(accel_dev)) {
                dev_err(&pdev->dev, "Failed to enable aer\n");
                ret = -EFAULT;
                goto out_err_free_reg;
index 32102e27e559cc7162a4c109fb98c4baf9c09e7e..d2ae293d0df6a82a0f7a9a74c196b52f3197dbb6 100644 (file)
@@ -175,7 +175,6 @@ static const struct pci_error_handlers adf_err_handler = {
 /**
  * adf_enable_aer() - Enable Advance Error Reporting for acceleration device
  * @accel_dev:  Pointer to acceleration device.
- * @adf:        PCI device driver owning the given acceleration device.
  *
  * Function enables PCI Advance Error Reporting for the
  * QAT acceleration device accel_dev.
@@ -183,11 +182,12 @@ static const struct pci_error_handlers adf_err_handler = {
  *
  * Return: 0 on success, error code otherwise.
  */
-int adf_enable_aer(struct adf_accel_dev *accel_dev, struct pci_driver *adf)
+int adf_enable_aer(struct adf_accel_dev *accel_dev)
 {
        struct pci_dev *pdev = accel_to_pci_dev(accel_dev);
+       struct pci_driver *pdrv = pdev->driver;
 
-       adf->err_handler = &adf_err_handler;
+       pdrv->err_handler = &adf_err_handler;
        pci_enable_pcie_error_reporting(pdev);
        return 0;
 }
index ebfcb4ea618d5d2d0fcf4943e0857d49b63648b7..f22342f612c1d0795b35371d1ff44bd6e26ab844 100644 (file)
@@ -95,7 +95,7 @@ void adf_ae_fw_release(struct adf_accel_dev *accel_dev);
 int adf_ae_start(struct adf_accel_dev *accel_dev);
 int adf_ae_stop(struct adf_accel_dev *accel_dev);
 
-int adf_enable_aer(struct adf_accel_dev *accel_dev, struct pci_driver *adf);
+int adf_enable_aer(struct adf_accel_dev *accel_dev);
 void adf_disable_aer(struct adf_accel_dev *accel_dev);
 void adf_reset_sbr(struct adf_accel_dev *accel_dev);
 void adf_reset_flr(struct adf_accel_dev *accel_dev);
index 1e0a5965d9b6880eb58f2b2d67676b11ed40e161..ecb4f6f20e22b040a78f9bd2c0232cf4ba75b4e5 100644 (file)
@@ -200,7 +200,7 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        }
        pci_set_master(pdev);
 
-       if (adf_enable_aer(accel_dev, &adf_driver)) {
+       if (adf_enable_aer(accel_dev)) {
                dev_err(&pdev->dev, "Failed to enable aer\n");
                ret = -EFAULT;
                goto out_err_free_reg;