crypto: qat - report an error if MMP file size is too large
authorJack Xu <jack.xu@intel.com>
Mon, 17 May 2021 09:13:14 +0000 (05:13 -0400)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 28 May 2021 06:20:40 +0000 (14:20 +0800)
Change the return status to error if MMP file size is too large so the
driver load fails early if a large MMP firmware is loaded.

Signed-off-by: Jack Xu <jack.xu@intel.com>
Co-developed-by: Zhehui Xiang <zhehui.xiang@intel.com>
Signed-off-by: Zhehui Xiang <zhehui.xiang@intel.com>
Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/qat/qat_common/qat_uclo.c

index 8adf25769128a4000280e0496385866818262909..ed1343bb36ac7e5710cf0a27c4f1bdfabe19fd77 100644 (file)
@@ -1552,10 +1552,8 @@ int qat_uclo_wr_mimage(struct icp_qat_fw_loader_handle *handle,
                qat_uclo_ummap_auth_fw(handle, &desc);
        } else {
                if (handle->chip_info->mmp_sram_size < mem_size) {
-                       dev_dbg(&handle->pci_dev->dev,
-                               "QAT MMP fw not loaded for device 0x%x",
-                               handle->pci_dev->device);
-                       return status;
+                       pr_err("QAT: MMP size is too large: 0x%x\n", mem_size);
+                       return -EFBIG;
                }
                qat_uclo_wr_sram_by_words(handle, 0, addr_ptr, mem_size);
        }