RDMA/hns: Do not use !! for values that are already bool when calling hr_reg_write()
authorWeihang Li <liweihang@huawei.com>
Mon, 21 Jun 2021 08:00:35 +0000 (16:00 +0800)
committerJason Gunthorpe <jgg@nvidia.com>
Mon, 21 Jun 2021 18:03:40 +0000 (15:03 -0300)
There is no need to use "!!" before "eq->eqe_size ==
HNS_ROCE_V3_EQE_SIZE", or sparse will complain about "dubious: x & !y".

Fixes: 782832f25404 ("RDMA/hns: Simplify the function config_eqc()")
Link: https://lore.kernel.org/r/1624262443-24528-2-git-send-email-liweihang@huawei.com
Signed-off-by: Weihang Li <liweihang@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/hns/hns_roce_hw_v2.c

index f67b17523dd3b5953d4482492067880e12fdf608..de2af114e45e486ac54516f694398d441aa16610 100644 (file)
@@ -6264,8 +6264,7 @@ static int config_eqc(struct hns_roce_dev *hr_dev, struct hns_roce_eq *eq,
        hr_reg_write(eqc, EQC_EQ_CONS_INDX, HNS_ROCE_EQ_INIT_CONS_IDX);
        hr_reg_write(eqc, EQC_NEX_EQE_BA_L, eqe_ba[1] >> 12);
        hr_reg_write(eqc, EQC_NEX_EQE_BA_H, eqe_ba[1] >> 44);
-       hr_reg_write(eqc, EQC_EQE_SIZE,
-                    !!(eq->eqe_size == HNS_ROCE_V3_EQE_SIZE));
+       hr_reg_write(eqc, EQC_EQE_SIZE, eq->eqe_size == HNS_ROCE_V3_EQE_SIZE);
 
        return 0;
 }