usb: cdns3: Use platform_get_irq_byname() to get the interrupt
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Mon, 20 Dec 2021 01:04:10 +0000 (01:04 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 21 Dec 2021 07:51:57 +0000 (08:51 +0100)
platform_get_resource_byname(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.

In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq_byname().

Reviewed-by: Roger Quadros <rogerq@kernel.org>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://lore.kernel.org/r/20211220010411.12075-6-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/cdns3/cdns3-plat.c

index 4d0f027e5bd3a347a057a6cef250da82d1cf0976..dc068e940ed59450131cbb790786b7bfda0ef1b1 100644 (file)
@@ -13,6 +13,7 @@
  */
 
 #include <linux/module.h>
+#include <linux/irq.h>
 #include <linux/kernel.h>
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
@@ -65,13 +66,14 @@ static int cdns3_plat_probe(struct platform_device *pdev)
 
        platform_set_drvdata(pdev, cdns);
 
-       res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, "host");
-       if (!res) {
-               dev_err(dev, "missing host IRQ\n");
-               return -ENODEV;
-       }
+       ret = platform_get_irq_byname(pdev, "host");
+       if (ret < 0)
+               return ret;
 
-       cdns->xhci_res[0] = *res;
+       cdns->xhci_res[0].start = ret;
+       cdns->xhci_res[0].end = ret;
+       cdns->xhci_res[0].flags = IORESOURCE_IRQ | irq_get_trigger_type(ret);
+       cdns->xhci_res[0].name = "host";
 
        res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "xhci");
        if (!res) {