i2c: i801: Remove unneeded warning after wait_event_timeout timeout
authorHeiner Kallweit <hkallweit1@gmail.com>
Fri, 21 May 2021 22:00:28 +0000 (00:00 +0200)
committerWolfram Sang <wsa@kernel.org>
Thu, 27 May 2021 20:08:36 +0000 (22:08 +0200)
When passing -ETIMEDOUT to i801_check_post() it will emit a timeout
error message. I don't see much benefit in an additional warning
stating more or less the same.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Tested-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-i801.c

index 99d446763530ea4028d449048d3a9e3f3486aeea..bfea94d027757340e348abdc1f0d3443a9627bf3 100644 (file)
@@ -509,11 +509,9 @@ static int i801_transaction(struct i801_priv *priv, int xact)
                result = wait_event_timeout(priv->waitq,
                                            (status = priv->status),
                                            adap->timeout);
-               if (!result) {
+               if (!result)
                        status = -ETIMEDOUT;
-                       dev_warn(&priv->pci_dev->dev,
-                                "Timeout waiting for interrupt!\n");
-               }
+
                priv->status = 0;
                return i801_check_post(priv, status);
        }
@@ -732,11 +730,9 @@ static int i801_block_transaction_byte_by_byte(struct i801_priv *priv,
                result = wait_event_timeout(priv->waitq,
                                            (status = priv->status),
                                            adap->timeout);
-               if (!result) {
+               if (!result)
                        status = -ETIMEDOUT;
-                       dev_warn(&priv->pci_dev->dev,
-                                "Timeout waiting for interrupt!\n");
-               }
+
                priv->status = 0;
                return i801_check_post(priv, status);
        }