scsi: ufs: ufs-qcom: Remove redundant dev_err() call in ufs_qcom_init()
authorYe Bin <yebin10@huawei.com>
Fri, 9 Apr 2021 07:55:22 +0000 (15:55 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 13 Apr 2021 03:25:30 +0000 (23:25 -0400)
There is a error message within devm_ioremap_resource() already, so remove
the dev_err() call to avoid redundant error message.

Link: https://lore.kernel.org/r/20210409075522.2111083-1-yebin10@huawei.com
Reported-by: Hulk Robot <hulkci@huawei.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Ye Bin <yebin10@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufs-qcom.c

index 9b711d6aac543878fe46edc14802b927e8bcda35..2a3dd21da6a6057a2ea3022f477182df810f07cd 100644 (file)
@@ -1071,13 +1071,8 @@ static int ufs_qcom_init(struct ufs_hba *hba)
                if (res) {
                        host->dev_ref_clk_ctrl_mmio =
                                        devm_ioremap_resource(dev, res);
-                       if (IS_ERR(host->dev_ref_clk_ctrl_mmio)) {
-                               dev_warn(dev,
-                                       "%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n",
-                                       __func__,
-                                       PTR_ERR(host->dev_ref_clk_ctrl_mmio));
+                       if (IS_ERR(host->dev_ref_clk_ctrl_mmio))
                                host->dev_ref_clk_ctrl_mmio = NULL;
-                       }
                        host->dev_ref_clk_en_mask = BIT(5);
                }
        }