tty: n_gsm: name gsm tty device minors
authorDaniel Starke <daniel.starke@siemens.com>
Wed, 31 Aug 2022 07:37:56 +0000 (09:37 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 Sep 2022 14:04:46 +0000 (16:04 +0200)
Add a macro which defines the possible number of virtual devices for n_gsm
to improve code readability.

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
Link: https://lore.kernel.org/r/20220831073800.7459-2-daniel.starke@siemens.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/n_gsm.c

index d831dfccc60324072a741921cdee3aa1400328ee..250849846b3648c05c94aee441336ed652e51789 100644 (file)
@@ -164,6 +164,9 @@ struct gsm_dlci {
        struct net_device *net; /* network interface, if created */
 };
 
+/* Total number of supported devices */
+#define GSM_TTY_MINORS         256
+
 /* DLCI 0, 62/63 are special or reserved see gsmtty_open */
 
 #define NUM_DLCI               64
@@ -3741,7 +3744,7 @@ static int __init gsm_init(void)
                return status;
        }
 
-       gsm_tty_driver = tty_alloc_driver(256, TTY_DRIVER_REAL_RAW |
+       gsm_tty_driver = tty_alloc_driver(GSM_TTY_MINORS, TTY_DRIVER_REAL_RAW |
                        TTY_DRIVER_DYNAMIC_DEV | TTY_DRIVER_HARDWARE_BREAK);
        if (IS_ERR(gsm_tty_driver)) {
                pr_err("gsm_init: tty allocation failed.\n");