spi: microchip-core: Simplify some error message
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 5 Aug 2022 21:33:17 +0000 (23:33 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 15 Aug 2022 11:18:41 +0000 (12:18 +0100)
dev_err_probe() already prints the error code in a human readable way, so
there is no need to duplicate it as a numerical value at the end of the
message.

Moreover, in the case of devm_clk_get() it would only display '0' because
'ret' is know to be 0 at this point.

Fixes: cdeaf3a99a02 ("spi: microchip-core: switch to use dev_err_probe()")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/fb894ecec68e03fb7fc9353027c8b1a2610833d7.1659735153.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-microchip-core.c

index ce4385330b1910e8f56af52cb019f0e29680a8ad..d352844c798c956191f566683eb9f09dce174381 100644 (file)
@@ -548,12 +548,12 @@ static int mchp_corespi_probe(struct platform_device *pdev)
                               IRQF_SHARED, dev_name(&pdev->dev), master);
        if (ret)
                return dev_err_probe(&pdev->dev, ret,
-                                    "could not request irq: %d\n", ret);
+                                    "could not request irq\n");
 
        spi->clk = devm_clk_get(&pdev->dev, NULL);
        if (IS_ERR(spi->clk))
                return dev_err_probe(&pdev->dev, PTR_ERR(spi->clk),
-                                    "could not get clk: %d\n", ret);
+                                    "could not get clk\n");
 
        ret = clk_prepare_enable(spi->clk);
        if (ret)