tests/virtio-scsi: Clean up global variable shadowing
authorPhilippe Mathieu-Daudé <philmd@linaro.org>
Mon, 9 Oct 2023 10:02:44 +0000 (12:02 +0200)
committerThomas Huth <thuth@redhat.com>
Fri, 27 Oct 2023 07:39:08 +0000 (09:39 +0200)
Rename the (unused) 'allow' argument, following the pattern
used by the other tests in this file. This fixes:

  tests/qtest/virtio-scsi-test.c:159:61: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
  static void hotplug(void *obj, void *data, QGuestAllocator *alloc)
                                                              ^
  tests/qtest/virtio-scsi-test.c:37:25: note: previous declaration is here
  static QGuestAllocator *alloc;
                          ^

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-By: Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20231009100251.56019-4-philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
tests/qtest/virtio-scsi-test.c

index ceaa7f2415be7e1c17fb3973cdb6753f8d0dabcd..db10d572d0fcf0e2a12a0f808f3c868d115a9e7e 100644 (file)
@@ -156,7 +156,7 @@ static QVirtioSCSIQueues *qvirtio_scsi_init(QVirtioDevice *dev)
     return vs;
 }
 
-static void hotplug(void *obj, void *data, QGuestAllocator *alloc)
+static void hotplug(void *obj, void *data, QGuestAllocator *t_alloc)
 {
     QTestState *qts = global_qtest;