block: don't check ->rq_disk in merges
authorChristoph Hellwig <hch@lst.de>
Fri, 26 Nov 2021 12:17:59 +0000 (13:17 +0100)
committerJens Axboe <axboe@kernel.dk>
Mon, 29 Nov 2021 13:41:29 +0000 (06:41 -0700)
There is a 1:1 relationship between request_queues and gendisks now, so
no need for these extra checks.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Link: https://lore.kernel.org/r/20211126121802.2090656-3-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-merge.c

index e07f5a1ae86e2180ba9e49506549b8b2f7548cdd..4de34a332c9fdd7ba5a95632e15885032d13d065 100644 (file)
@@ -777,8 +777,7 @@ static struct request *attempt_merge(struct request_queue *q,
        if (req_op(req) != req_op(next))
                return NULL;
 
-       if (rq_data_dir(req) != rq_data_dir(next)
-           || req->rq_disk != next->rq_disk)
+       if (rq_data_dir(req) != rq_data_dir(next))
                return NULL;
 
        if (req_op(req) == REQ_OP_WRITE_SAME &&
@@ -905,10 +904,6 @@ bool blk_rq_merge_ok(struct request *rq, struct bio *bio)
        if (bio_data_dir(bio) != rq_data_dir(rq))
                return false;
 
-       /* must be same device */
-       if (rq->rq_disk != bio->bi_bdev->bd_disk)
-               return false;
-
        /* only merge integrity protected bio into ditto rq */
        if (blk_integrity_merge_bio(rq->q, rq, bio) == false)
                return false;