projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2d1609a
)
scsi: qla2xxx: Call scsi_done() directly
author
Bart Van Assche
<bvanassche@acm.org>
Thu, 7 Oct 2021 20:29:00 +0000
(13:29 -0700)
committer
Martin K. Petersen
<martin.petersen@oracle.com>
Sun, 17 Oct 2021 01:31:40 +0000
(21:31 -0400)
Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.
Link:
https://lore.kernel.org/r/20211007202923.2174984-66-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_os.c
patch
|
blob
|
history
diff --git
a/drivers/scsi/qla2xxx/qla_os.c
b/drivers/scsi/qla2xxx/qla_os.c
index 03ff2596715b9a4d9c76659d4e6210858828a722..5d576a3ba14f4df1159e48be3ea5e0538c799075 100644
(file)
--- a/
drivers/scsi/qla2xxx/qla_os.c
+++ b/
drivers/scsi/qla2xxx/qla_os.c
@@
-737,7
+737,7
@@
void qla2x00_sp_compl(srb_t *sp, int res)
sp->free(sp);
cmd->result = res;
CMD_SP(cmd) = NULL;
-
cmd->
scsi_done(cmd);
+ scsi_done(cmd);
if (comp)
complete(comp);
}
@@
-828,7
+828,7
@@
void qla2xxx_qpair_sp_compl(srb_t *sp, int res)
sp->free(sp);
cmd->result = res;
CMD_SP(cmd) = NULL;
-
cmd->
scsi_done(cmd);
+ scsi_done(cmd);
if (comp)
complete(comp);
}
@@
-950,7
+950,7
@@
qc24_target_busy:
return SCSI_MLQUEUE_TARGET_BUSY;
qc24_fail_command:
-
cmd->
scsi_done(cmd);
+ scsi_done(cmd);
return 0;
}
@@
-1038,7
+1038,7
@@
qc24_target_busy:
return SCSI_MLQUEUE_TARGET_BUSY;
qc24_fail_command:
-
cmd->
scsi_done(cmd);
+ scsi_done(cmd);
return 0;
}