RDMA/vmw_pvrdma: Remove unnecessary check on wr->opcode

wr->opcode is unsigned; checking if it is negative is unnecessary. Fix
this issue by removing the check.

Fixes: 29c8d9eba550 ("IB: Add vmw_pvrdma driver")
Link: https://lore.kernel.org/r/20230605183728.47021-1-bryantan@vmware.com
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/07c48eee-0aca-48ee-897a-38588c341c41@kili.mountain
Signed-off-by: Bryan Tan <bryantan@vmware.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c
index f83cd4a9d99234c64bebddba19b9f0205f121af6..98b2a0090bf2a13f54eecf7277fdbc26f506eac0 100644 (file)
--- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c
+++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c
@@ -709,14 +709,6 @@ int pvrdma_post_send(struct ib_qp *ibqp, const struct ib_send_wr *wr,
                        goto out;
                }
 
-               if (unlikely(wr->opcode < 0)) {
-                       dev_warn_ratelimited(&dev->pdev->dev,
-                                            "invalid send opcode\n");
-                       *bad_wr = wr;
-                       ret = -EINVAL;
-                       goto out;
-               }
-
                /*
                 * Only support UD, RC.
                 * Need to check opcode table for thorough checking.