i2c: st: use 'time_left' variable with wait_for_completion_timeout()
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Sat, 27 Apr 2024 20:35:59 +0000 (22:35 +0200)
committerAndi Shyti <andi.shyti@kernel.org>
Sun, 5 May 2024 22:56:52 +0000 (00:56 +0200)
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

timeout = wait_for_completion_timeout(...)
if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-st.c

index dbb93394ff94625ba6e4a354a08c224692befa47..5e01fe3dbb63f1dd1fa12ed3a7ec683d767fde02 100644 (file)
@@ -647,7 +647,7 @@ static int st_i2c_xfer_msg(struct st_i2c_dev *i2c_dev, struct i2c_msg *msg,
 {
        struct st_i2c_client *c = &i2c_dev->client;
        u32 ctl, i2c, it;
-       unsigned long timeout;
+       unsigned long time_left;
        int ret;
 
        c->addr         = i2c_8bit_addr_from_msg(msg);
@@ -685,11 +685,11 @@ static int st_i2c_xfer_msg(struct st_i2c_dev *i2c_dev, struct i2c_msg *msg,
                st_i2c_set_bits(i2c_dev->base + SSC_I2C, SSC_I2C_STRTG);
        }
 
-       timeout = wait_for_completion_timeout(&i2c_dev->complete,
-                       i2c_dev->adap.timeout);
+       time_left = wait_for_completion_timeout(&i2c_dev->complete,
+                                               i2c_dev->adap.timeout);
        ret = c->result;
 
-       if (!timeout)
+       if (!time_left)
                ret = -ETIMEDOUT;
 
        i2c = SSC_I2C_STOPG | SSC_I2C_REPSTRTG;