selftests: KVM: Replace optarg with arg in guest_modes_cmdline
authorShaoqin Huang <shahuang@redhat.com>
Thu, 2 Feb 2023 02:57:15 +0000 (10:57 +0800)
committerSean Christopherson <seanjc@google.com>
Wed, 8 Feb 2023 14:38:47 +0000 (06:38 -0800)
The parameter arg in guest_modes_cmdline not being used now, and the
optarg should be replaced with arg in guest_modes_cmdline.

And this is the chance to change strtoul() to atoi_non_negative(), since
guest mode ID will never be negative.

Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
Fixes: e42ac777d661 ("KVM: selftests: Factor out guest mode code")
Reviewed-by: Andrew Jones <andrew.jones@linux.dev>
Reviewed-by: Vipin Sharma <vipinsh@google.com>
Link: https://lore.kernel.org/r/20230202025716.216323-1-shahuang@redhat.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
tools/testing/selftests/kvm/lib/guest_modes.c

index 99a575bbbc52a78af1640d2cb7122704b0744908..1df3ce4b16fd86a3f1750700d1392872a60cbf92 100644 (file)
@@ -127,7 +127,7 @@ void guest_modes_cmdline(const char *arg)
                mode_selected = true;
        }
 
-       mode = strtoul(optarg, NULL, 10);
+       mode = atoi_non_negative("Guest mode ID", arg);
        TEST_ASSERT(mode < NUM_VM_MODES, "Guest mode ID %d too big", mode);
        guest_modes[mode].enabled = true;
 }