dmaengine: dw-edma: Fix wrong interrupt bit set for HDMA
authorKory Maincent <kory.maincent@bootlin.com>
Mon, 29 Jan 2024 16:25:58 +0000 (17:25 +0100)
committerVinod Koul <vkoul@kernel.org>
Wed, 7 Feb 2024 08:30:51 +0000 (09:30 +0100)
Instead of setting HDMA_V0_LOCAL_ABORT_INT_EN bit, HDMA_V0_LOCAL_STOP_INT_EN
bit got set twice, due to which the abort interrupt is not getting generated for
HDMA. Fix it by setting the correct interrupt enable bit.

Fixes: e74c39573d35 ("dmaengine: dw-edma: Add support for native HDMA")
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
Link: https://lore.kernel.org/r/20240129-b4-feature_hdma_mainline-v7-2-8e8c1acb7a46@bootlin.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/dw-edma/dw-hdma-v0-core.c

index 1f4cb7db54756df119e7673ddec1eb44ec4452d0..108f9127aaaaf31d7a74e8118b5400a9dedb60f5 100644 (file)
@@ -236,7 +236,7 @@ static void dw_hdma_v0_core_start(struct dw_edma_chunk *chunk, bool first)
                /* Interrupt enable&unmask - done, abort */
                tmp = GET_CH_32(dw, chan->dir, chan->id, int_setup) |
                      HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK |
-                     HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_STOP_INT_EN;
+                     HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN;
                SET_CH_32(dw, chan->dir, chan->id, int_setup, tmp);
                /* Channel control */
                SET_CH_32(dw, chan->dir, chan->id, control1, HDMA_V0_LINKLIST_EN);