b43: Use fallthrough pseudo-keyword
authorGustavo A. R. Silva <gustavoars@kernel.org>
Fri, 21 Aug 2020 06:42:18 +0000 (01:42 -0500)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 27 Aug 2020 13:08:22 +0000 (16:08 +0300)
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1].

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200821064218.GA19502@embeddedor
drivers/net/wireless/broadcom/b43/dma.c
drivers/net/wireless/broadcom/b43/main.c
drivers/net/wireless/broadcom/b43/phy_n.c
drivers/net/wireless/broadcom/b43/pio.c
drivers/net/wireless/broadcom/b43/tables_nphy.c

index ca671fc13116f8c34ea37e998287424d48f91a60..9a7c62bd5e431651aa347e194a1a2c51e393e0ec 100644 (file)
@@ -1317,7 +1317,7 @@ static struct b43_dmaring *select_ring_by_priority(struct b43_wldev *dev,
                switch (queue_prio) {
                default:
                        B43_WARN_ON(1);
-                       /* fallthrough */
+                       fallthrough;
                case 0:
                        ring = dev->dma.tx_ring_AC_VO;
                        break;
index 2a29fa69f692c03363f130e5154003c9085560d3..f175dbaffc30027ef987e10e18695dc4409f3329 100644 (file)
@@ -1874,7 +1874,7 @@ static void b43_handle_firmware_panic(struct b43_wldev *dev)
        switch (reason) {
        default:
                b43dbg(dev->wl, "The panic reason is unknown.\n");
-               /* fallthrough */
+               fallthrough;
        case B43_FWPANIC_DIE:
                /* Do not restart the controller or firmware.
                 * The device is nonfunctional from now on.
@@ -2268,7 +2268,7 @@ fw_ready:
                size = be32_to_cpu(hdr->size);
                if (size != ctx->blob->size - sizeof(struct b43_fw_header))
                        goto err_format;
-               /* fallthrough */
+               fallthrough;
        case B43_FW_TYPE_IV:
                if (hdr->ver != 1)
                        goto err_format;
@@ -3180,7 +3180,7 @@ static void b43_rate_memory_init(struct b43_wldev *dev)
                b43_rate_memory_write(dev, B43_OFDM_RATE_36MB, 1);
                b43_rate_memory_write(dev, B43_OFDM_RATE_48MB, 1);
                b43_rate_memory_write(dev, B43_OFDM_RATE_54MB, 1);
-               /* fallthrough */
+               fallthrough;
        case B43_PHYTYPE_B:
                b43_rate_memory_write(dev, B43_CCK_RATE_1MB, 0);
                b43_rate_memory_write(dev, B43_CCK_RATE_2MB, 0);
@@ -5331,7 +5331,7 @@ static void b43_supported_bands(struct b43_wldev *dev, bool *have_2ghz_phy,
                /* There are 14e4:4321 PCI devs with 2.4 GHz BCM4321 (N-PHY) */
                if (dev->phy.type != B43_PHYTYPE_G)
                        break;
-               /* fall through */
+               fallthrough;
        case 0x4313: /* BCM4311 */
        case 0x431a: /* BCM4318 */
        case 0x432a: /* BCM4321 */
index 9e4d61e64adf56ed134c0ab0ed3f570c24a6ffe3..b669dff24b6e0f84a05287224556a66377f957ab 100644 (file)
@@ -3239,7 +3239,7 @@ static void b43_nphy_workarounds_rev3plus(struct b43_wldev *dev)
                if (!(dev->phy.rev >= 4 &&
                      b43_current_band(dev->wl) == NL80211_BAND_2GHZ))
                        break;
-               /* FALL THROUGH */
+               fallthrough;
        case 0:
        case 1:
                b43_ntab_write_bulk(dev, B43_NTAB16(8, 0x08), 4, vmid);
index 1a11c5dfb8d98f1625247aea8f534d3c0a5b076e..8c28a9250cd19a45da54a1e6c7ec0d9315698ab7 100644 (file)
@@ -294,7 +294,7 @@ static struct b43_pio_txqueue *select_queue_by_priority(struct b43_wldev *dev,
                switch (queue_prio) {
                default:
                        B43_WARN_ON(1);
-                       /* fallthrough */
+                       fallthrough;
                case 0:
                        q = dev->pio.tx_queue_AC_VO;
                        break;
index 7957db94e84c6899fa3e1d30ff66e1e34f3721c1..41a25d909d0dddbf94d6c52f65585f98bf0692bb 100644 (file)
@@ -3717,7 +3717,7 @@ const u32 *b43_nphy_get_tx_gain_table(struct b43_wldev *dev)
                case 5:
                        if (sprom->fem.ghz2.extpa_gain == 3)
                                return b43_ntab_tx_gain_epa_rev3_hi_pwr_2g;
-                       /* fall through */
+                       fallthrough;
                case 4:
                case 3:
                        return b43_ntab_tx_gain_epa_rev3_2g;