media: staging: rkisp1: rsz: supported formats are the isp's src formats, not sink...
authorDafna Hirschfeld <dafna.hirschfeld@collabora.com>
Thu, 18 Jun 2020 11:35:15 +0000 (13:35 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Sat, 4 Jul 2020 10:32:47 +0000 (12:32 +0200)
The rkisp1_resizer's enum callback 'rkisp1_rsz_enum_mbus_code'
calls the enum callback of the 'rkisp1_isp' on it's video sink pad.
This is a bug, the resizer should support the same formats
supported by the 'rkisp1_isp' on the source pad (not the sink pad).

Fixes: 56e3b29f9f6b "media: staging: rkisp1: add streaming paths"
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Acked-by: Helen Koike <helen.koike@collabora.com>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/rkisp1/rkisp1-resizer.c

index 26fb41053f56cb66ced68a244fa3a6ad75a19d31..27f4b948ad4154964340bea96f5ce11c74f1f5c1 100644 (file)
@@ -437,8 +437,8 @@ static int rkisp1_rsz_enum_mbus_code(struct v4l2_subdev *sd,
        u32 pad = code->pad;
        int ret;
 
-       /* supported mbus codes are the same in isp sink pad */
-       code->pad = RKISP1_ISP_PAD_SINK_VIDEO;
+       /* supported mbus codes are the same in isp video src pad */
+       code->pad = RKISP1_ISP_PAD_SOURCE_VIDEO;
        ret = v4l2_subdev_call(&rsz->rkisp1->isp.sd, pad, enum_mbus_code,
                               &dummy_cfg, code);