scsi: ppa: Call scsi_done() directly
authorBart Van Assche <bvanassche@acm.org>
Thu, 7 Oct 2021 20:28:56 +0000 (13:28 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sun, 17 Oct 2021 01:31:40 +0000 (21:31 -0400)
Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-62-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ppa.c

index 977315fdc254b910ac74050a4cda756332bd20e5..799ad8562e2486608edee3b0c0a335deeb36cbec 100644 (file)
@@ -665,7 +665,7 @@ static void ppa_interrupt(struct work_struct *work)
 
        dev->cur_cmd = NULL;
 
-       cmd->scsi_done(cmd);
+       scsi_done(cmd);
 }
 
 static int ppa_engine(ppa_struct *dev, struct scsi_cmnd *cmd)
@@ -798,7 +798,6 @@ static int ppa_queuecommand_lck(struct scsi_cmnd *cmd,
        dev->failed = 0;
        dev->jstart = jiffies;
        dev->cur_cmd = cmd;
-       cmd->scsi_done = done;
        cmd->result = DID_ERROR << 16;  /* default return code */
        cmd->SCp.phase = 0;     /* bus free */