[media] imon: use complete() instead of complete_all()

There is only one waiter for the completion, therefore there is no need
to use complete_all(). Let's make that clear by using complete() instead
of complete_all().

While we are at it, we do a small optimization with the reinitialization
of the completion before we use it.

The usage pattern of the completion is:

waiter context                          waker context

send_packet()
  init_completion()
  usb_submit_urb()
  wait_for_completion_interruptible()

                                        usb_tx_callback()
                                          complete()

                                        imon_disonnect()
                                          complete()

Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c
index bd807fa4cb9fa0f4694640e2e9afc80a093e4db4..0785a24af8fc4acca86e11b74b372b8d9af29dcd 100644 (file)
--- a/drivers/media/rc/imon.c
+++ b/drivers/media/rc/imon.c
@@ -607,7 +607,7 @@ static int send_packet(struct imon_context *ictx)
                ictx->tx_urb->actual_length = 0;
        }
 
-       init_completion(&ictx->tx.finished);
+       reinit_completion(&ictx->tx.finished);
        ictx->tx.busy = true;
        smp_rmb(); /* ensure later readers know we're busy */
 
@@ -2216,6 +2216,8 @@ static struct imon_context *imon_init_intf0(struct usb_interface *intf,
        ictx->tx_urb = tx_urb;
        ictx->rf_device = false;
 
+       init_completion(&ictx->tx.finished);
+
        ictx->vendor  = le16_to_cpu(ictx->usbdev_intf0->descriptor.idVendor);
        ictx->product = le16_to_cpu(ictx->usbdev_intf0->descriptor.idProduct);
 
@@ -2491,7 +2493,7 @@ static void imon_disconnect(struct usb_interface *interface)
        /* Abort ongoing write */
        if (ictx->tx.busy) {
                usb_kill_urb(ictx->tx_urb);
-               complete_all(&ictx->tx.finished);
+               complete(&ictx->tx.finished);
        }
 
        if (ifnum == 0) {